public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Default CONFIG_DEBUG_MUTEXES to n
@ 2006-04-15 22:45 Martin J. Bligh
  2006-04-15 23:06 ` Adrian Bunk
  0 siblings, 1 reply; 2+ messages in thread
From: Martin J. Bligh @ 2006-04-15 22:45 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

CONFIG_DEBUG_MUTEXES has a significant performant impact (reduced perf
of reaim by 50% on ia32 NUMA boxes). It should not be on by default.

Signed-off-by: Martin J. Bligh <mbligh@google.com>



[-- Attachment #2: 2.6.17-rc1_no_mutex_dbg --]
[-- Type: text/plain, Size: 722 bytes --]

diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.17-rc1/lib/Kconfig.debug 2.6.17-rc1_no_mutex_dbg/lib/Kconfig.debug
--- linux-2.6.17-rc1/lib/Kconfig.debug	2006-04-15 15:28:54.000000000 -0700
+++ 2.6.17-rc1_no_mutex_dbg/lib/Kconfig.debug	2006-04-15 15:44:14.000000000 -0700
@@ -101,7 +101,7 @@ config DEBUG_PREEMPT
 
 config DEBUG_MUTEXES
 	bool "Mutex debugging, deadlock detection"
-	default y
+	default n
 	depends on DEBUG_KERNEL
 	help
 	 This allows mutex semantics violations and mutex related deadlocks
@@ -109,6 +109,7 @@ config DEBUG_MUTEXES
 
 config DEBUG_SPINLOCK
 	bool "Spinlock debugging"
+	default n
 	depends on DEBUG_KERNEL
 	help
 	  Say Y here and build SMP to catch missing spinlock initialization

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Default CONFIG_DEBUG_MUTEXES to n
  2006-04-15 22:45 [PATCH] Default CONFIG_DEBUG_MUTEXES to n Martin J. Bligh
@ 2006-04-15 23:06 ` Adrian Bunk
  0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-04-15 23:06 UTC (permalink / raw)
  To: Martin J. Bligh; +Cc: Andrew Morton, Linux Kernel Mailing List

On Sat, Apr 15, 2006 at 03:45:38PM -0700, Martin J. Bligh wrote:
> CONFIG_DEBUG_MUTEXES has a significant performant impact (reduced perf
> of reaim by 50% on ia32 NUMA boxes). It should not be on by default.
> 
> Signed-off-by: Martin J. Bligh <mbligh@google.com>
> 
> 

> diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.17-rc1/lib/Kconfig.debug 2.6.17-rc1_no_mutex_dbg/lib/Kconfig.debug
> --- linux-2.6.17-rc1/lib/Kconfig.debug	2006-04-15 15:28:54.000000000 -0700
> +++ 2.6.17-rc1_no_mutex_dbg/lib/Kconfig.debug	2006-04-15 15:44:14.000000000 -0700
> @@ -101,7 +101,7 @@ config DEBUG_PREEMPT
>  
>  config DEBUG_MUTEXES
>  	bool "Mutex debugging, deadlock detection"
> -	default y
> +	default n
>...
>  config DEBUG_SPINLOCK
>  	bool "Spinlock debugging"
> +	default n
>...

"default n" has no effect and can be removed.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-04-15 23:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-15 22:45 [PATCH] Default CONFIG_DEBUG_MUTEXES to n Martin J. Bligh
2006-04-15 23:06 ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox