From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S932260AbWDRPOH@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932260AbWDRPOH (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 18 Apr 2006 11:14:07 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932270AbWDRPOH
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 18 Apr 2006 11:14:07 -0400
Received: from gateway-1237.mvista.com ([63.81.120.158]:35364 "EHLO
	gateway-1237.mvista.com") by vger.kernel.org with ESMTP
	id S932260AbWDRPOG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 18 Apr 2006 11:14:06 -0400
Message-ID: <44450238.8090701@mvista.com>
Date: Tue, 18 Apr 2006 10:14:00 -0500
From: Corey Minyard <cminyard@mvista.com>
User-Agent: Mozilla Thunderbird 1.0.6-7.5.20060mdk (X11/20050322)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, minyard@mvista.com,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root
 static
References: <20060418150609.GF11582@stusta.de>
In-Reply-To: <20060418150609.GF11582@stusta.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Yes, I thought this had already been added.  Please add it.

Thanks,

-Corey

Adrian Bunk wrote:

>This patch makes the needlessly global struct proc_ipmi_root static.
>
>Besides this, it removes an unused #ifdef CONFIG_PROC_FS from 
>include/linux/ipmi.h.
>
>---
>
>This patch was already sent on:
>- 13 Apr 2006
>
>BTW: Please add an entry for IPMI to MAINTAINERS.
>
> drivers/char/ipmi/ipmi_msghandler.c |    3 +--
> include/linux/ipmi.h                |    4 ----
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
>--- linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h.old	2006-04-12 22:32:08.000000000 +0200
>+++ linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h	2006-04-12 22:32:20.000000000 +0200
>@@ -210,11 +210,7 @@
>  */
> #include <linux/list.h>
> #include <linux/module.h>
>-
>-#ifdef CONFIG_PROC_FS
> #include <linux/proc_fs.h>
>-extern struct proc_dir_entry *proc_ipmi_root;
>-#endif /* CONFIG_PROC_FS */
> 
> /* Opaque type for a IPMI message user.  One of these is needed to
>    send and receive messages. */
>--- linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c.old	2006-04-12 22:32:29.000000000 +0200
>+++ linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c	2006-04-12 22:32:45.000000000 +0200
>@@ -57,8 +57,7 @@
> static int initialized = 0;
> 
> #ifdef CONFIG_PROC_FS
>-struct proc_dir_entry *proc_ipmi_root = NULL;
>-EXPORT_SYMBOL(proc_ipmi_root);
>+static struct proc_dir_entry *proc_ipmi_root = NULL;
> #endif /* CONFIG_PROC_FS */
> 
> #define MAX_EVENTS_IN_QUEUE	25
>
>  
>