From: Gunther Mayer <gunther.mayer@gmx.net>
To: Zinx Verituse <zinx@epicsol.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: ide-cd.c, "MEDIUM_ERROR" handling
Date: Tue, 18 Apr 2006 17:20:49 +0200 [thread overview]
Message-ID: <444503D1.50705@gmx.net> (raw)
In-Reply-To: <20060418011839.GA10619@atlantis.chaos>
Zinx Verituse wrote:
>I recently bought a DVD drive which appears to not retry enough when it's
>having trouble reading a disc - I'm requesting an option (or changing the
>default behavior) so that this drive is actually usable with the Linux
>ide-cd drivers - specificly, the code:
> } else if (sense_key == MEDIUM_ERROR) {
> /* No point in re-trying a zillion times on a bad
> * sector... If we got here the error is not correctable */
> ide_dump_status (drive, "media error (bad sector)", stat);
> do_end_request = 1;
> }
>needs to be disabled for my drive to read CDs properly.
>
>With this code enabled, no retries are made, and the kernel sees medium errors
>and returns bad data to the application reading;
>
It would be a kernel bug if it returns bad data. It should return an
error code to the application.
- The device should implement a decent retry strategy.
- There are special forensic applications which can be tuned to re-read
bad sectors multiple times if needed.
next prev parent reply other threads:[~2006-04-18 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 1:18 ide-cd.c, "MEDIUM_ERROR" handling Zinx Verituse
2006-04-18 11:04 ` Alan Cox
2006-04-18 15:20 ` Gunther Mayer [this message]
2006-04-18 16:54 ` Erik Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444503D1.50705@gmx.net \
--to=gunther.mayer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zinx@epicsol.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox