From: Jiri Slaby <jirislaby@gmail.com>
To: Thayumanavar Sachithanantham <thayumk@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
info-linux@geode.amd.com, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net
Subject: Re: [PATCH]drivers/char/cs5535_gpio.c:call cdev_del during module_exit to unmap kobject references and other cleanups.
Date: Wed, 19 Apr 2006 11:35:26 +0200 [thread overview]
Message-ID: <4446045E.7070208@gmail.com> (raw)
In-Reply-To: <3b8510d80604190051v78c8757fibd30a5abf3efa24f@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Thayumanavar Sachithanantham napsal(a):
> During module unloading, cdev_del be called to unmap cdev related
> kobject references and other cleanups(such as inode->i_cdev being set
> to NULL) which prevents the OOPS upon subsequent loading ,usage and
> unloading of modules(as seen in the mail thread:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=114533640609018&w=2).
>
> Removed test of gpio_base as it is unneeded and will not be zero at
> module unload time.
>
> Signed-off-by: Thayumanavar Sachithanantham <thayumk@gmail.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
>
> --- linux-2.6/drivers/char/cs5535_gpio.c.orig 2006-04-17
> 21:37:25.000000000 -0700
> +++ linux-2.6/drivers/char/cs5535_gpio.c 2006-04-17 23:05:49.000000000 -0700
> @@ -241,9 +241,9 @@ static int __init cs5535_gpio_init(void)
> static void __exit cs5535_gpio_cleanup(void)
> {
> dev_t dev_id = MKDEV(major, 0);
> + cdev_del(&cs5535_gpio_cdev);
Spaces, again.
regards,
- --
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFERgReMsxVwznUen4RArG+AKCBJTe9mOLLXXHPyrzpt3Fm52ZA2gCcCcL3
duNa3zAPb2D0u/z8oWvvh+8=
=atPm
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2006-04-19 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-19 6:52 [PATCH]drivers/char/cs5535_gpio.c:call cdev_del during module_exit to unmap kobject references and other cleanups Thayumanavar Sachithanantham
2006-04-19 7:15 ` Andrew Morton
2006-04-19 7:51 ` Thayumanavar Sachithanantham
2006-04-19 9:35 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4446045E.7070208@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=info-linux@geode.amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=thayumk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox