* [PATCH] PCI quirk: VIA IRQ fixup should only run for VIA southbridges
@ 2006-04-19 6:57 Chris Wedgwood
2006-04-19 9:56 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wedgwood @ 2006-04-19 6:57 UTC (permalink / raw)
To: LKML; +Cc: Alan Cox, Andrew Morton
Alan Cox pointed out that the VIA 'IRQ fixup' was erroneously running
on my system which has no VIA southbridge (but I do have a VIA IEEE
1394 device).
This should address that. I also changed "Via IRQ" to "VIA IRQ"
(initially I read Via as a capitalized via (by way/means of).
Signed-off-by: Chris Wedgwood <cw@f00f.org>
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 827550d..59a9e21 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -642,13 +642,15 @@ static void quirk_via_irq(struct pci_dev
new_irq = dev->irq & 0xf;
pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
if (new_irq != irq) {
- printk(KERN_INFO "PCI: Via IRQ fixup for %s, from %d to %d\n",
+ printk(KERN_INFO "PCI: VIA IRQ fixup for %s, from %d to %d\n",
pci_name(dev), irq, new_irq);
udelay(15); /* unknown if delay really needed */
pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
}
}
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
/*
* VIA VT82C598 has its device ID settable and many BIOSes
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI quirk: VIA IRQ fixup should only run for VIA southbridges
2006-04-19 6:57 [PATCH] PCI quirk: VIA IRQ fixup should only run for VIA southbridges Chris Wedgwood
@ 2006-04-19 9:56 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-04-19 9:56 UTC (permalink / raw)
To: Chris Wedgwood; +Cc: LKML, Alan Cox, Andrew Morton
Chris Wedgwood wrote:
> Alan Cox pointed out that the VIA 'IRQ fixup' was erroneously running
> on my system which has no VIA southbridge (but I do have a VIA IEEE
> 1394 device).
>
> This should address that. I also changed "Via IRQ" to "VIA IRQ"
> (initially I read Via as a capitalized via (by way/means of).
ACK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-19 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-19 6:57 [PATCH] PCI quirk: VIA IRQ fixup should only run for VIA southbridges Chris Wedgwood
2006-04-19 9:56 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox