From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966242AbdAKMul (ORCPT ); Wed, 11 Jan 2017 07:50:41 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:60976 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbdAKMuj (ORCPT ); Wed, 11 Jan 2017 07:50:39 -0500 X-AuditID: b6c32a37-f79606d000005083-7b-58762a1c9f10 From: Bartlomiej Zolnierkiewicz To: Kees Cook Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven , linux-fbdev@vger.kernel.org Subject: Re: [PATCH v2] video: fbdev: sh_mobile_lcdcfb: use designated initializers Date: Wed, 11 Jan 2017 13:50:29 +0100 Message-id: <4446544.3TN0Epkxz7@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20161220201049.GA18463@beast> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsWy7bCmvq6MVlmEwdS5+hZzZ09itDjTnWtx ou8Dq8XlXXPYHFg8ZjdcZPGYeFbX4/MmuQDmKC6blNSczLLUIn27BK6MA88b2Aq6uSumTnnB 3sC4jLOLkYNDQsBEouFkchcjJ5ApJnHh3nq2LkYuDiGBHYwSl/pOskI47UwS798+Y4WoMpE4 276PHSKxnFGitesuM4TzlVHid8NSNpAqNgEriYntqxhBbBEBVYnvl5qZQWxmgVyJuXNfg00S FgiVWPlyF1gNC1DN0uf7mEBO4hXQlHj2uQgkLCrgJbFlXzsTiM0poC3xYNshdhCbV0BQ4sfk eywQI+Ul9u2fygph60icPbaOEeQeCYFmdol/Dx4wQ7wpK7HpADPEAy4SH56uhHpGWOLV8S3s ELa0xKp/t5gg7OmMEtt/S0DM2cwosWr3BKgia4nDxy9CLeOTePe1hxViPq9ER5sQRIkH0OtH WSDCjhInV/iAhIUE6iS+HX/NNoFRfhaSD2Yh+WAWkg8WMDKvYhRLLSjOTU8tNiww1itOzC0u zUvXS87P3cQITgxa5jsYN5zzOcQowMGoxMP74EVJhBBrYllxZe4hRgkOZiUR3hfqZRFCvCmJ lVWpRfnxRaU5qcWHGKU5WJTEeRc3WkcICaQnlqRmp6YWpBbBZJk4OKUaGBkmJDUl1B578fj0 1ofTiwX2MgVGnHRPd9zIeFt/+eSDbD1Mpt3y65rX2MbfmSm2QGeTMluZzXQJFb+fb3W+dJUf XrxvpV7d3t31h9YdNvz9uZQnblV+lk3DP7Y/hqWl9l6TZm8ysZuSvifEY56f7LZDRhECHyV2 bTp57ZWo/6oCQYMCVb+C10osxRmJhlrMRcWJAJ7W/yAIAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t9jAV0ZrbIIg0cHpCzmzp7EaHGmO9fi RN8HVovLu+awObB4zG64yOIx8ayux+dNcgHMUW42GamJKalFCql5yfkpmXnptkqhIW66FkoK eYm5qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLOPC8ga2gm7ti6pQX7A2Myzi7GDk5 JARMJM6272OHsMUkLtxbz9bFyMUhJLCUUWLBm/ssEM5XRontc0+wgFSxCVhJTGxfxQhiiwio Sny/1MwMYjML5Eqc/nIArEZYIFRi5ctdYDUsQDVLn+9j6mLk4OAV0JR49rkIJCwq4CWxZV87 E4jNKaAt8WDbIbAjhAQaGCVurbQBsXkFBCV+TL7HAjFeXmLf/qmsELaWxPqdx5kmMArMQlI2 C0nZLCRlCxiZVzFKpBYkFxQnpeca5qWW6xUn5haX5qXrJefnbmIER8szqR2MB3e5H2IU4GBU 4uF98KIkQog1say4MvcQowQHs5II7wv1sggh3pTEyqrUovz4otKc1OJDjKZA/01klhJNzgdG cl5JvKGJuYm5sYGFuaWliZGSOG/j7GfhQgLpiSWp2ampBalFMH1MHJxSDYzFmSFT2F+psvxM rBeRulf1b6PdP8WbWWL5bjazzO7dDg3o9M7LUlIQ7t1zy6qlZ2ZuwstpkhMOWXZZtFw1yV3v +2L1strZ96KOOkvNnBrafqLB8neQWJdcsfaV30v9JlR+/zY1m5vfZu75eEML0+byPRsNHjsF mu54bzl7TeS0V+WTHVWWT1ZiKc5INNRiLipOBADd36orrAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111125036epcas1p4e33130f8d8f154904494931ea1e49db3 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20161220201053epcas1p3440c5c2973397422318bae039948af8e X-RootMTR: 20161220201053epcas1p3440c5c2973397422318bae039948af8e References: <20161220201049.GA18463@beast> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, December 20, 2016 12:10:49 PM Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook > Reviewed-by: Geert Uytterhoeven Thanks, queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > v2: > - vertical columns, Bartlomiej Zolnierkiewicz > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index 82c0a8caa9b8..93469f94c09d 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -439,9 +439,9 @@ static unsigned long lcdc_sys_read_data(void *handle) > } > > static struct sh_mobile_lcdc_sys_bus_ops sh_mobile_lcdc_sys_bus_ops = { > - lcdc_sys_write_index, > - lcdc_sys_write_data, > - lcdc_sys_read_data, > + .write_index = lcdc_sys_write_index, > + .write_data = lcdc_sys_write_data, > + .read_data = lcdc_sys_read_data, > }; > > static int sh_mobile_lcdc_sginit(struct fb_info *info,