From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751058AbWDTP5M (ORCPT ); Thu, 20 Apr 2006 11:57:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751060AbWDTP5M (ORCPT ); Thu, 20 Apr 2006 11:57:12 -0400 Received: from fmr18.intel.com ([134.134.136.17]:43493 "EHLO orsfmr003.jf.intel.com") by vger.kernel.org with ESMTP id S1751057AbWDTP5L (ORCPT ); Thu, 20 Apr 2006 11:57:11 -0400 Message-ID: <4447AF4D.7030507@linux.intel.com> Date: Thu, 20 Apr 2006 19:57:01 +0400 From: Alexey Starikovskiy User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Matthew Garrett CC: "Yu, Luming" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] [PATCH] Make ACPI button driver an input device References: <554C5F4C5BA7384EB2B412FD46A3BAD1332980@pdsmsx411.ccr.corp.intel.com> <20060420073713.GA25735@srcf.ucam.org> <4447AA59.8010300@linux.intel.com> <20060420153848.GA29726@srcf.ucam.org> In-Reply-To: <20060420153848.GA29726@srcf.ucam.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Matthew Garrett wrote: > On Thu, Apr 20, 2006 at 07:35:53PM +0400, Alexey Starikovskiy wrote: > >> Could it be more sensible to use kevent and dbus for sending all events >> from ACPI? > > For most of the events, probably. I'm less convinced by the button > driver - sleep and power buttons can also generate keycodes rather than > ACPI events, and so getting the button driver to behave like an input > device adds consistency. > I think you will agree that ACPI buttons are special and will need special handling even in input stream... Generic application does not need to know if power, sleep, or lid button is pressed, so you will need to intercept them from input stream... I cannot find any reason to mix these buttons into input, do you?