Re: [2.6 Patch] isdn4linux: Siemens Gigaset base driver: fix disconnect handling

[Tilman Schmidt <tilman@imap.cc>]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

On 20.04.2006 17:32, Adrian Bunk wrote:

> On Thu, Apr 20, 2006 at 08:21:20AM -0700, Randy.Dunlap wrote:
[...]
>>>>Tilman Schmidt <tilman@imap.cc> wrote:
>>>>
>>>>>--- linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c	2006-04-19 15:15:49.000000000 +0200
>>>>>+++ local/drivers/isdn/gigaset/bas-gigaset.c	2006-04-19 01:19:41.000000000 +0200
>>
>>Both filename lines should begin one level above "drivers/".
>>They can be named linux* or a/ and b/ or foo/ and bar/ or whatever.
>>The patch needs to apply using "patch -p1".

Well, so it does.

> The only thing that is wrong is
>   linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c
>                                             ^^^^^

I see. I'll avoid that in the future.

Randy.Dunlap again:

>> This is all well-documented.  Please review:
>> 
>> linux-2.6.current/Documentation/SubmittingPatches
>> http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
>> http://linux.yyz.us/patch-format.html
>> 
>> and let us know if anything there needs to be clarified.

What wasn't obvious to me from these documents is that the "---" path
must also be "-p1 conforming" (so to say), as the "patch -p1" command
itself only requires that for the "+++" path.

Unfortunately I can't think of a wording that would have prevented that
misunderstanding for me. Perhaps a native English speaker might come up
with something.

Thanks
Tilman

-- 
Tilman Schmidt                          E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]