From: Nick Piggin <nickpiggin@yahoo.com.au>
To: David Woodhouse <dwmw2@infradead.org>
Cc: akpm@osdl.org, andrea@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Shrink rbtree
Date: Fri, 21 Apr 2006 23:06:07 +1000 [thread overview]
Message-ID: <4448D8BF.9040601@yahoo.com.au> (raw)
In-Reply-To: <1145623663.11909.139.camel@pmac.infradead.org>
Hi David,
Doesn't seem like a bad idea...
David Woodhouse wrote:
> Our rbtree implementation uses a whole integer for colour information.
> In fact, because of alignment constraints on a 64-bit machine it'll be a
> whole 64 bits there. We only need a single bit, though -- and we know
> the pointers are always going to be aligned. So let's just use the
How do we know the pointers are always going to be aligned? IIRC
struct address_space needed to be explicitly aligned when doing
this trick in page->mapping because some platform byte aligned it.
Nick
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-04-21 18:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 12:47 [PATCH] Shrink rbtree David Woodhouse
2006-04-21 13:06 ` Nick Piggin [this message]
2006-04-21 19:08 ` David Woodhouse
2006-04-21 20:57 ` Hugh Dickins
2006-04-21 22:12 ` David Woodhouse
2006-04-23 13:03 ` Hugh Dickins
2006-04-21 18:24 ` Zach Brown
2006-04-21 19:06 ` David Woodhouse
2006-04-21 19:25 ` Zach Brown
2006-04-22 1:09 ` Andrew Morton
2006-04-22 1:10 ` Andrew Morton
2006-04-22 1:21 ` Andrew Morton
2006-04-22 1:29 ` David Woodhouse
2006-04-22 12:29 ` Ingo Oeser
2006-04-22 13:38 ` David Woodhouse
2006-04-22 22:55 ` Ingo Oeser
2006-04-23 16:36 ` Steven Rostedt
2006-04-23 17:20 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4448D8BF.9040601@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox