From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932293AbWDUNSv (ORCPT ); Fri, 21 Apr 2006 09:18:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932297AbWDUNSv (ORCPT ); Fri, 21 Apr 2006 09:18:51 -0400 Received: from relay4.usu.ru ([194.226.235.39]:55169 "EHLO relay4.usu.ru") by vger.kernel.org with ESMTP id S932293AbWDUNSu (ORCPT ); Fri, 21 Apr 2006 09:18:50 -0400 Message-ID: <4448DC4C.6010500@ums.usu.ru> Date: Fri, 21 Apr 2006 19:21:16 +0600 From: "Alexander E. Patrakov" User-Agent: Mozilla/5.0 (X11; U; Linux i686; ru-RU; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0 MIME-Version: 1.0 To: Chris Rankin Cc: greg@kroah.com, linux-kernel@vger.kernel.org Subject: Re: [patch 05/22] : Fix hotplug race during device registration References: <20060421125329.4210.qmail@web52910.mail.yahoo.com> In-Reply-To: <20060421125329.4210.qmail@web52910.mail.yahoo.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-AntiVirus: checked by AntiVir MailGate (version: 2.0.1.15; AVE: 6.34.0.24; VDF: 6.34.0.217; host: usu2.usu.ru) X-AV-Checked: ClamAV using ClamSMTP@relay4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Chris Rankin wrote: > With reference to this patch: > http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;h=2731570eba5b35a21c311dd587057c39805082f1;hp=dfb62998866ae2e298139164a85ec0757b7f3fc7;hb=9469d458b90bfb9117cbb488cfa645d94c3921b1;f=net/core/dev.c > > Doesn't this patch introduce another bug when registration fails, because reg_state is left as > NETREG_REGISTERED? Look at the old code again. This is not a new bug. The old code fails registration, does a printk, and then sets dev->reg_state = NETREG_REGISTERED. So this doesn't revoke my signed-off-by line. -- Alexander E. Patrakov