Re: [RFC] [PATCH] Make ACPI button driver an input device

Dmitry Torokhov
2006-04-24T14:45:33Z

On 4/19/06, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Wed, Apr 19, 2006 at 10:04:47PM +0200, Dominik Brodowski wrote:
> > On Wed, Apr 19, 2006 at 08:53:58PM +0100, Matthew Garrett wrote:
> > > +++ a/include/linux/input.h 2006-04-19 20:49:18 +0100
> > > @@ -344,6 +344,7 @@
> > > #define KEY_FORWARDMAIL 233
> > > #define KEY_SAVE 234
> > > #define KEY_DOCUMENTS 235
> > > +#define KEY_LID 237
> >
> > What about 236?
>
> I sent a patch last month that uses 236 for KEY_BATTERY, so decided not
> to conflict with it.
>

Yes, I still need to apply it.

Matthew, I would recommend not adding KEY_LID but using one of the
switch codes (SW_0?) for the lid.

Richard, on your handhelds what switch would be most similar to
notebook's lid? Should we alias one of the switches to SW_LID?

--
Dmitry