public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Bernard Pidoux <bpidoux@free.fr>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Bernard Pidoux <pidoux@ccr.jussieu.fr>,
	linux-kernel@vger.kernel.org
Subject: Re: [kernel 2.6] Patch for mxser.c driver
Date: Mon, 24 Apr 2006 20:36:42 +0159	[thread overview]
Message-ID: <444D1AD1.4000301@gmail.com> (raw)
In-Reply-To: <444C913B.3020706@free.fr>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bernard Pidoux napsal(a):
> Hi,
> 
> The multiport serial adapter I wanted to use is a four ports C104H/PCI
> SmartIO.
> 
> I just received from Moxa support a beta version of the driver
> (mxser_1.9.1.tgz).
> 
> Acording to readme.txt file
> 
>    The Smartio/Industio/UPCI family Linux driver supports following
> multiport
>    boards.
> 
>     - 2 ports multiport board
>         CP-102U, CP-102UL
>         CP-132U-I, CP-132UL,
>         CP-132, CP-132I, CP132S, CP-132IS,
>         CI-132, CI-132I, CI-132IS,
>         (C102H, C102HI, C102HIS, C102P, CP-102, CP-102S)
> 
>     - 4 ports multiport board
>         CP-104EL,
>         CP-104UL, CP-104JU,
>         CP-134U, CP-134U-I
>         C104H/PCI, C104HS/PCI,
>         CP-114, CP-114I, CP-114S, CP-114IS,
>         C104H, C104HS,
>         CI-104J, CI-104JS
>         CI-134, CI-134I, CI-134IS,
>         (C114HI, CT-114I, C104P)
> 
>     - 8 ports multiport board
>         CP-118EL, CP-168EL,
>         CP-118U, CP-168U,
>         C168H/PCI,
>         C168H, C168HS,
>         (C168P)
> 
> I did not have any problem to compile this beta version of driver 1.9
> and utilities under kernel 2.6.16 with gcc 4.0.3
Thanks for sources. The problem is, they still use deprecated api, they still
pci_find_device, despite I applied them to correct it and they promise to at
least try their best, unfortunately with no effect :(. I guess, if they don't
convert it to pci probing, the driver won't be altered (delete 'if LINUXVERSION'
and so on) to be re-merged as a new version.
The driver needs to be rewritten as a whole (macros, whitespace, probing, maybe
it missed some new tty api changes and so on). Maybe I get into that on summer
holidays or somebody may do so earlier, but merging driver in present state is
maybe unwanted.

regards,
- --
Jiri Slaby         www.fi.muni.cz/~xslaby
\_.-^-._   jirislaby@gmail.com   _.-^-._/
B67499670407CE62ACC8 22A032CC55C339D47A7E
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFETRrRMsxVwznUen4RAvxBAJwIhDvzgs0zGJfkfUp8U2bOU3N3kwCeNk3Z
e5f+9FVPKtVd+JbmVuMDeGg=
=niri
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2006-04-24 18:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-11 21:20 [kernel 2.6] Patch for mxser.c driver Bernard Pidoux
2006-04-11 22:21 ` Jiri Slaby
2006-04-12  9:36   ` Alan Cox
2006-04-24  8:50     ` Bernard Pidoux
2006-04-24 10:52       ` Jiri Slaby
2006-04-24 18:37       ` Jiri Slaby [this message]
2006-04-24 20:16         ` Alan Cox
2006-04-11 22:24 ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=444D1AD1.4000301@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bpidoux@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pidoux@ccr.jussieu.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox