Re: [RFC][PATCH] swsusp: support creating bigger images

Pavel Machek
2006-04-28T09:24:23Z

Hi!

> OK, I'm waiting for Nick to respond, then. :-)
>
> Still I'd like to change one more thing in the final patch. Namely,
> instead of this:
>
> @@ -153,6 +153,10 @@ static int snapshot_ioctl(struct inode *
>         case SNAPSHOT_UNFREEZE:
>                 if (!data->frozen)
>                         break;
> +               if (data->ready && in_suspend) {
> +                       error = -EPERM;
> +                       break;
> +               }
>                 down(&pm_sem);
>                 thaw_processes();
>                 enable_nonboot_cpus();
>
> I'd like to do:
>
> case SNAPSHOT_UNFREEZE:
> if (!data->frozen)
> break;
> + if (data->ready)
> + swsusp_free();
> down(&pm_sem);
> thaw_processes();
> enable_nonboot_cpus();
>
> so unfreeze() won't return the error.

Seems okay to me...
Pavel
--
Thanks for all the (sleeping) penguins.