From: Peter Staubach <staubach@redhat.com>
To: Xin Zhao <uszhaoxin@gmail.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: question about nfs_execute_read: why do we need to do lock_kernel?
Date: Tue, 25 Apr 2006 10:37:39 -0400 [thread overview]
Message-ID: <444E3433.1040703@redhat.com> (raw)
In-Reply-To: <4ae3c140604250708w438545c1lfa66233fdaa63cc@mail.gmail.com>
Xin Zhao wrote:
>Thanks for your reply. So the only reason is for rpc auditing? If so,
>why not just lock the code that updating the audit information? Now
>the code is:
>
>lock_kernel()
>rpc_execute()
>unlock_kernel().
>
>That means the kernel will be blocked when rpc is executed, which
>could take long time. Even if rpc_execute() won't take very long, this
>implementation still looks inefficient. That's why I am a little
>confused on this point.
>
>Any further thought?
>
I would suggest looking at the semantics of the BKL. They don't end up
implying what you are suggesting. The kernel isn't really locked for
the duration of the over the wire RPC.
Thanx...
ps
next prev parent reply other threads:[~2006-04-25 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 4:57 question about nfs_execute_read: why do we need to do lock_kernel? Xin Zhao
2006-04-25 5:09 ` Trond Myklebust
2006-04-25 14:08 ` Xin Zhao
2006-04-25 14:26 ` Trond Myklebust
2006-04-25 14:37 ` Peter Staubach [this message]
2006-04-25 15:31 ` Xin Zhao
2006-04-25 15:57 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444E3433.1040703@redhat.com \
--to=staubach@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
--cc=uszhaoxin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox