From: Jeff Garzik <jeff@garzik.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [git patch] fuse fixes
Date: Wed, 26 Apr 2006 16:03:16 -0400 [thread overview]
Message-ID: <444FD204.7040708@garzik.org> (raw)
In-Reply-To: <E1FYJ0r-0006Tv-00@dorka.pomaz.szeredi.hu>
Miklos Szeredi wrote:
> Linus,
>
> Please pull from 'for-linus' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/mszeredi/fuse.git
Reading the code...
> struct fuse_req *fuse_request_alloc(void)
> {
> struct fuse_req *req = kmem_cache_alloc(fuse_req_cachep, SLAB_KERNEL);
> if (req)
> fuse_request_init(req);
> return req;
> }
This function is called from everywhere, and so, it looks like it should
use SLAB_NOFS rather than SLAB_KERNEL. I would audit every GFP_KERNEL
and SLAB_KERNEL usage, and consider replacing with SLAB_NOFS or GFP_NOFS.
Jeff
next prev parent reply other threads:[~2006-04-26 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 8:35 [git patch] fuse fixes Miklos Szeredi
2006-04-25 8:38 ` [PATCH 1/4] Revert "[fuse] fix deadlock between fuse_put_super() and request_end()" Miklos Szeredi
2006-04-25 21:50 ` Linus Torvalds
2006-04-25 8:39 ` [PATCH 2/4] [fuse] fix deadlock between fuse_put_super() and request_end() Miklos Szeredi
2006-04-25 8:39 ` [PATCH 3/4] [fuse] fix race between checking and setting file->private_data Miklos Szeredi
2006-04-25 8:40 ` [PATCH 4/4] [doc] add paragraph about 'fs' subsystem to sysfs.txt Miklos Szeredi
2006-04-25 15:52 ` Randy.Dunlap
2006-04-26 20:03 ` Jeff Garzik [this message]
2006-04-27 6:08 ` [git patch] fuse fixes Miklos Szeredi
2006-04-27 10:33 ` Jeff Garzik
2006-04-27 14:38 ` Miklos Szeredi
-- strict thread matches above, loose matches on Subject: below --
2006-04-26 9:15 Miklos Szeredi
2006-04-11 19:42 Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444FD204.7040708@garzik.org \
--to=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).