Re: [PATCH] drivers/scsi/sd.c: fix uninitialized variable in handling medium errors

Mark Lord
2006-04-26T23:20:39Z

Andrew Morton wrote:
>
> It'd be nice to have something simple-and-obvious for the
> simple-and-obvious -stable maintainers.

That's why I kept the original patch very simple and focused,
rather than trying to fix all of the convoluted code around it.

It's nice and simple, and *looks* correct.

A longer term cleanup of that function is better left to James!

> That's if we think -stable needs this fixed.

Let's say a bunch of read bio's get coalesced into a single
200+ sector request. This then fails on one single bad sector
out of the 200+. Without the patch, there is a very good chance
that sd.c will simply fail the entire request, all 200+ sectors.

With the patch, it will fail the first block, and then retry
the remaining blocks. And repeat this until something works,
or until everything has failed one by one.

Better, but still not the best.

What I need to have happen when a request is failed due to bad-media,
is have it split the request into a sequence of single-block requests
that are passed to the LLD one at a time. The ones with real bad
sectors will then be independently failed, and the rest will get done.

Much better. Much more complex.

I'm thinking about something like that, just not sure whether to put it
(initially) in libata, sd.c, or the block layer.

Cheers