Re: [PATCH] drivers/scsi/sd.c: fix uninitialized variable in handling medium errors

James Bottomley
2006-04-26T23:22:13Z

On Wed, 2006-04-26 at 16:14 -0700, Andrew Morton wrote:
> It'd be nice to have something simple-and-obvious for the
> simple-and-obvious -stable maintainers. That's if we think -stable needs
> this fixed.

Well .. the original will do for that.

> > + int sector_size_div =
> > + 512 / SCpnt->device->sector_size;
> > + error_sector /= sector_size_div;
>
> You sure about this bit?

Yes. If the <hardware sector size> is < 512 bytes then to convert the
listed error sector to the standard 512 byte sector size block index, we
have to divide (512/<hardware sector size>).

James