From: "Jan Beulich" <jbeulich@novell.com>
To: "Linus Torvalds" <torvalds@osdl.org>
Cc: <akpm@osdl.org>, "Andi Kleen" <ak@suse.de>,
<linux-kernel@vger.kernel.org>, <discuss@x86-64.org>
Subject: [discuss] Re: [PATCH] [3/4] i386: Fix overflow in e820_all_mapped
Date: Fri, 28 Apr 2006 09:07:19 +0200 [thread overview]
Message-ID: <4451DB47.76E4.0078.0@novell.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0604272237430.3701@g5.osdl.org>
>>> Linus Torvalds <torvalds@osdl.org> 28.04.06 07:39 >>>
>
>
>On Fri, 28 Apr 2006, Andi Kleen wrote:
>>
>> The 32bit version of e820_all_mapped() needs to use u64 to avoid
>> overflows on PAE systems. Pointed out by Jan Beulich
>
>I don't think that's true.
>
>It can't be called with 64-bit arguments anyway. If the base address
>doesn't fit in 32-bit, we'd be screwed in other places, afaik.
The arguments don't necessarily need to be u64, but (at least some of)
the calculations inside the function do. Otherwise, a region starting
below 4G and extending to or beyond 4G would not be considered
correctly.
Jan
next prev parent reply other threads:[~2006-04-28 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 5:28 [PATCH] [3/4] i386: Fix overflow in e820_all_mapped Andi Kleen
2006-04-28 5:39 ` Linus Torvalds
2006-04-28 6:08 ` Andi Kleen
2006-04-28 14:52 ` Linus Torvalds
2006-04-28 7:07 ` Jan Beulich [this message]
2006-04-28 7:34 ` [discuss] " Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4451DB47.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox