From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DE5543CEE3 for ; Mon, 11 May 2026 16:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778518388; cv=none; b=XjM6EqxNwL064T0n7/lhqDsmAVxgWrIrqVcd2tbOs6yRqRsnEFhP0f100RCadOikzlb0mTKb99LE7JpQnU6YWD/wbTp41RPa6GSosLXNlvvEaktUl96J23pg1Nkmy4ba5UvYQr1ZRTEKDHE+T6TnYlH6MrXRt3caM8QYRjyN5CQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778518388; c=relaxed/simple; bh=wSrCs5UnMR4P3H76hMnvwVit9yGI7o6BnKDT+QqjiXE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RvjhI1r7wlCp/YNOFVpw5lA1YhZLV0wBS1/TIiMBqBR8XHSqt4RMesdpnhDPQNPszvHYUDFTozP1GQ4A7GBBuvOg6JjSBo9sDT9FRAtnUROiN1jWp/3w88KneeAB9cHhW148vpnld4JZiTTOEsDbryLFXHYHtRkXxYvEs/OnB6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ajJF1xjE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ajJF1xjE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04924C2BCB0; Mon, 11 May 2026 16:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778518387; bh=wSrCs5UnMR4P3H76hMnvwVit9yGI7o6BnKDT+QqjiXE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ajJF1xjEckAWgdOWlX6Dz4ySD45UoXxyjeF5lP4rl6nLBlrqwZLhbSLSxcSzy0Njd VwUrnri1baFETwpo7+m/vErAL4bym1yL0f/izF0AFVisuTtNWikCdhA2fWaVadZyty N5SaN1RpOrSKmlAGKR9yWDfwY4yoOmsujcH22S/vZqtcbFwFPDG6CjP47a7UZiKzZ7 AavEVt3nyC2T183jyBVqhyxxg1OAwt4h16WogPPm0pRlVKk0Xv57WpvVQrTzeVX/xx NqmUbz7U1Dg2PqkU/neAjQ6G8QmhG6I25MczxIES/cLPliYfF9ZRPznqFXV+50DMSL cmdaRKH/g0oWQ== Message-ID: <4456c6a3-93b5-4f47-9c04-f7953fcbd987@kernel.org> Date: Mon, 11 May 2026 18:53:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/22] mm/page_alloc: don't overload migratetype in find_suitable_fallback() Content-Language: en-US To: Brendan Jackman , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, rppt@kernel.org, Sumit Garg , derkling@google.com, reijiw@google.com, Will Deacon , rientjes@google.com, "Kalyazin, Nikita" , patrick.roy@linux.dev, "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Yosry Ahmed References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> <20260320-page_alloc-unmapped-v2-9-28bf1bd54f41@google.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/11/26 18:44, Brendan Jackman wrote: > On Mon May 11, 2026 at 1:51 PM UTC, Vlastimil Babka (SUSE) wrote: >> On 3/20/26 19:23, Brendan Jackman wrote: >>> This function currently returns a signed integer that encodes status >>> in-band, as negative numbers, along with a migratetype. >>> >>> This function is about to be updated to a mode where this in-band >>> signaling no longer makes sense. Therefore, switch to a more >>> explicit/verbose style that encodes the status and migratetype >>> separately. >>> >>> In the spirit of making things more explicit, also create an enum to >>> avoid using magic integer literals with special meanings. This enables >>> documenting the values at their definition instead of in one of the >>> callers. >>> >>> Signed-off-by: Brendan Jackman >> >> Reviewed-by: Vlastimil Babka (SUSE) > > Thanks, > > This and the prior patch could arguably just be considered independent > cleanups, shall I send them on their own? I guess why not, fewer patches in the patchset :) You're probably going to need to rebase this on current mm tree anyway for the next posting? > Equally if they feel like "churn" I'm happy to keep them in this > patchset.