* [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface
@ 2006-05-02 9:32 Razvan Gavril
2006-05-02 20:05 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Razvan Gavril @ 2006-05-02 9:32 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: ftdi_sio-ZWave.patch --]
[-- Type: text/x-patch, Size: 1156 bytes --]
diff -Nur linux-2.6.16.12/drivers/usb/serial/ftdi_sio.c linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.c
--- linux-2.6.16.12/drivers/usb/serial/ftdi_sio.c 2006-05-01 15:14:26.000000000 -0400
+++ linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.c 2006-05-02 05:12:10.000000000 -0400
@@ -307,6 +307,7 @@
static struct usb_device_id id_table_combined [] = {
+ { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
diff -Nur linux-2.6.16.12/drivers/usb/serial/ftdi_sio.h linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.h
--- linux-2.6.16.12/drivers/usb/serial/ftdi_sio.h 2006-05-01 15:14:26.000000000 -0400
+++ linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.h 2006-05-02 05:13:00.000000000 -0400
@@ -380,6 +380,9 @@
/* Pyramid Computer GmbH */
#define FTDI_PYRAMID_PID 0xE6C8 /* Pyramid Appliance Display */
+/* ACT Solutions HomePro ZWave interface (http://www.act-solutions.com/HomePro.htm) */
+#define FTDI_ACTZWAVE_PID 0xF2D0
+
/*
* Posiflex inc retail equipment (http://www.posiflex.com.tw)
*/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface
2006-05-02 9:32 [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface Razvan Gavril
@ 2006-05-02 20:05 ` Greg KH
2006-05-03 12:18 ` Razvan Gavril
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2006-05-02 20:05 UTC (permalink / raw)
To: Razvan Gavril; +Cc: linux-kernel
On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
Care to diff this against 2.6.17-rc3? Lots of ftdi new device ids have
been added there.
You also forgot to add a "Signed-off-by:" line :(
> diff -Nur linux-2.6.16.12/drivers/usb/serial/ftdi_sio.c linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.c
> --- linux-2.6.16.12/drivers/usb/serial/ftdi_sio.c 2006-05-01 15:14:26.000000000 -0400
> +++ linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.c 2006-05-02 05:12:10.000000000 -0400
> @@ -307,6 +307,7 @@
>
>
> static struct usb_device_id id_table_combined [] = {
> + { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
> diff -Nur linux-2.6.16.12/drivers/usb/serial/ftdi_sio.h linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.h
> --- linux-2.6.16.12/drivers/usb/serial/ftdi_sio.h 2006-05-01 15:14:26.000000000 -0400
> +++ linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.h 2006-05-02 05:13:00.000000000 -0400
> @@ -380,6 +380,9 @@
> /* Pyramid Computer GmbH */
> #define FTDI_PYRAMID_PID 0xE6C8 /* Pyramid Appliance Display */
>
> +/* ACT Solutions HomePro ZWave interface (http://www.act-solutions.com/HomePro.htm) */
> +#define FTDI_ACTZWAVE_PID 0xF2D0
Please use a tab here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface
2006-05-02 20:05 ` Greg KH
@ 2006-05-03 12:18 ` Razvan Gavril
2006-05-03 17:43 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Razvan Gavril @ 2006-05-03 12:18 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
Greg KH wrote:
> On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
>
> Care to diff this against 2.6.17-rc3? Lots of ftdi new device ids have
> been added there.
>
> You also forgot to add a "Signed-off-by:" line :(
Signed-Off By: Razvan Gavril <razvan.g@plutohome.com>
---
diff -Nur linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c
linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c
--- linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c 2006-05-03
15:12:01.000000000 +0300
+++ linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c 2006-05-03
15:04:39.000000000 +0300
@@ -307,6 +307,7 @@
static struct usb_device_id id_table_combined [] = {
+ { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
diff -Nur linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.h
linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.h
--- linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.h 2006-05-03
15:09:33.000000000 +0300
+++ linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.h 2006-05-03
15:13:26.000000000 +0300
@@ -32,6 +32,10 @@
#define FTDI_NF_RIC_PID 0x0001 /* Product Id */
+/* ACT Solutions HomePro ZWave interface
(http://www.act-solutions.com/HomePro.htm) */
+#define FTDI_ACTZWAVE_PID 0xF2D0
+
+
/* www.irtrans.de device */
#define FTDI_IRTRANS_PID 0xFC60 /* Product Id */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface
2006-05-03 12:18 ` Razvan Gavril
@ 2006-05-03 17:43 ` Greg KH
2006-05-04 8:35 ` Razvan Gavril
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2006-05-03 17:43 UTC (permalink / raw)
To: Razvan Gavril; +Cc: linux-kernel
On Wed, May 03, 2006 at 03:18:56PM +0300, Razvan Gavril wrote:
> Greg KH wrote:
> >On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
> >
> >Care to diff this against 2.6.17-rc3? Lots of ftdi new device ids have
> >been added there.
> >
> >You also forgot to add a "Signed-off-by:" line :(
>
> Signed-Off By: Razvan Gavril <razvan.g@plutohome.com>
Care to add a good text for what the patch does?
> ---
>
> diff -Nur linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c
> linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c
> --- linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c 2006-05-03
> 15:12:01.000000000 +0300
The patch is line wrapped :(
> +++ linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c 2006-05-03
> 15:04:39.000000000 +0300
> @@ -307,6 +307,7 @@
>
>
> static struct usb_device_id id_table_combined [] = {
> + { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
And the tabs were stripped by your email client :(
Care to try again?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface
2006-05-03 17:43 ` Greg KH
@ 2006-05-04 8:35 ` Razvan Gavril
0 siblings, 0 replies; 5+ messages in thread
From: Razvan Gavril @ 2006-05-04 8:35 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
Sorry, this is the first patch that i ever submitted, next time I'll be
more careful. The patch add the product id to support the zwave
ZCU000-USB computer interface.
here is the patch:
Signed-off-by: Razvan Gavril <razvan.g@plutohome.com>
[-- Attachment #2: ftdi_sio.patch --]
[-- Type: text/x-patch, Size: 1121 bytes --]
diff -Naur linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c
--- linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c 2006-05-03 15:12:01.000000000 +0300
+++ linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c 2006-05-03 15:04:39.000000000 +0300
@@ -307,6 +307,7 @@
static struct usb_device_id id_table_combined [] = {
+ { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
diff -Naur linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.h linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.h
--- linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.h 2006-05-03 15:09:33.000000000 +0300
+++ linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.h 2006-05-03 15:13:26.000000000 +0300
@@ -32,6 +32,10 @@
#define FTDI_NF_RIC_PID 0x0001 /* Product Id */
+/* ACT Solutions HomePro ZWave interface (http://www.act-solutions.com/HomePro.htm) */
+#define FTDI_ACTZWAVE_PID 0xF2D0
+
+
/* www.irtrans.de device */
#define FTDI_IRTRANS_PID 0xFC60 /* Product Id */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-05-04 8:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-02 9:32 [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface Razvan Gavril
2006-05-02 20:05 ` Greg KH
2006-05-03 12:18 ` Razvan Gavril
2006-05-03 17:43 ` Greg KH
2006-05-04 8:35 ` Razvan Gavril
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox