public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
	john stultz <johnstul@us.ibm.com>
Subject: Re: sched_clock() uses are broken
Date: Wed, 03 May 2006 00:21:07 +1000	[thread overview]
Message-ID: <44576AD3.500@yahoo.com.au> (raw)
In-Reply-To: <20060502132953.GA30146@flint.arm.linux.org.uk>

Russell King wrote:

> There are several solutions to this - the most obvious being that we
> need a function which returns the nanosecond difference between two
> sched_clock() return values, and this function needs to know how to
> handle the case where sched_clock() has wrapped.
> 
> IOW:
> 
> 	t0 = sched_clock();
> 	/* do something */
> 	t1 = sched_clock();
> 
> 	time_passed = sched_clock_diff(t1, t0);
> 
> Comments?
> 

There is another problem John pointed out to me: sched_clock (at least
on i386) can do tsc frequency scaling on the raw tsc value. I'm not
sure if this is still a problem (I'm not aware that it has been fixed),
however it would mean that between two sched_clock()s, the values
returned can be basically completely arbitrary.

What is needed is something like:
     t0 = get_cycles_unsynchronized();
     t1 = get_cycles_unsynchronized();
     ns = cycles_to_ns(t1, t0);

Where unsynchronized means not synchronized between CPUs.

This would still cause the `ns' value to be skewed if a frequency change
occured between t0 and t1, however at least it should be within some
realistic range (something like ns +/- ns * max freq / min freq).

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

  reply	other threads:[~2006-05-02 23:59 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-02 13:29 sched_clock() uses are broken Russell King
2006-05-02 14:21 ` Nick Piggin [this message]
2006-05-02 16:43 ` Andi Kleen
2006-05-02 16:50   ` Russell King
2006-05-02 17:01     ` Andi Kleen
2006-05-02 17:18       ` Nicolas Pitre
2006-05-02 18:55         ` Russell King
2006-05-02 19:05           ` Nicolas Pitre
2006-05-02 19:08             ` Russell King
2006-05-02 19:23               ` Nicolas Pitre
2006-05-02 21:35                 ` Russell King
2006-05-02 17:15     ` Nicolas Pitre
2006-05-04  3:50       ` George Anzinger
2006-05-04 14:18         ` Nicolas Pitre
2006-05-02 16:54   ` Christopher Friesen
2006-05-02 16:59     ` Andi Kleen
2006-05-02 17:07       ` Nick Piggin
2006-05-03  7:09         ` Mike Galbraith
2006-05-03  7:40           ` Andi Kleen
2006-05-03  9:11             ` Mike Galbraith
2006-05-03  9:16               ` Andi Kleen
2006-05-03  9:31                 ` Mike Galbraith
2006-05-07 12:33           ` Nick Piggin
2006-05-07 12:43             ` Russell King
2006-05-07 12:56               ` Nick Piggin
2006-05-07 13:00                 ` Nick Piggin
2006-05-07 13:18                   ` Russell King
2006-05-07 13:30                     ` Nick Piggin
2006-05-07 13:55                       ` Russell King
2006-05-07 14:04                         ` Nick Piggin
2006-05-07 16:03                           ` Andi Kleen
2006-05-07 16:53                       ` Russell King
2006-05-07 17:52                         ` Mike Galbraith
2006-05-07 17:37               ` Mike Galbraith
2006-05-07 17:32             ` Mike Galbraith
2006-05-08  4:14               ` Mike Galbraith
2006-05-08  4:37                 ` Mike Galbraith
2006-05-08  4:46                   ` Nick Piggin
2006-05-08  5:24                     ` Mike Galbraith
2006-05-08  5:30                       ` Nick Piggin
2006-05-04 20:02 ` Florian Paul Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44576AD3.500@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox