RE: Problems with EDAC coexisting with BIOS

Gross, Mark
2006-04-26T03:24:32Z

>-----Original Message-----
>From: Randy.Dunlap [mailto:rdunlap@xenotime.net]
>Sent: Tuesday, April 25, 2006 7:34 PM
>To: Gross, Mark
>Cc: minyard@acm.org; alan@lxorguk.ukuu.org.uk; bluesmoke-
>devel@lists.sourceforge.net; linux-kernel@vger.kernel.org; Carbonari,
>Steven; Ong, Soo Keong; Wang, Zhenyu Z
>Subject: Re: Problems with EDAC coexisting with BIOS
>
>On Tue, 25 Apr 2006 16:25:59 -0700 Gross, Mark wrote:
>
>>
>> How about printing nothing like it used too?
>>
>> See attached.
>>
>> Signed-off-by: Mark Gross
>
>Hi Mark,
>
>This small patch will need some cleaning up:
>
>1. Signed-off-by: Mark Gross <mark.gross@intel.com>
>
>2. Try not to use attachments. If you must, then make the attachment
> type be text instead of octet-stream.
>
>3. No need to init to 0:
>+static int force_function_unhide = 0;
>
>4. Typos:
>
>+ /* check to see if device 0 function 1 is enbaled if it isn't we
> enabled; it it isn't,
we
>+ * assume the BIOS has reserved it for a reason and is expecting
>+ * exclusive access, we take care to not violate that assumption
and
> not to violate
>+ * fail the probe. */
>
>5. indentation, typos, and at least one trailing space:
>
>+ if (!force_function_unhide && !(stat8 & (1 << 5))) {
>+ printk(KERN_INFO "contact your bios vendor to see if the
"
> Contact your BIOS
>+ "E752x error registers can be safely un-hidden\n");
> ^indent one more tab
>
>---

Thanks,
I'll get these tomorrow AM.

--mgross