* [PATCH] video: fbdev: omap: Add prototype for hwa742_update_window_async() to avoid build warning
@ 2022-05-29 6:47 Helge Deller
2022-05-29 11:14 ` Janusz Krzysztofik
0 siblings, 1 reply; 2+ messages in thread
From: Helge Deller @ 2022-05-29 6:47 UTC (permalink / raw)
To: linux-omap, Janusz Krzysztofik, linux-fbdev, linux-kernel
Cc: Imre Deak, Trilok Soni
The symbol hwa742_update_window_async() is exported, but there is no
prototype defined for it. That's why gcc complains:
drivers-video-fbdev-omap-hwa742.c:warning:no-previous-prototype-for-hwa742_update_window_async
Add the prototype, but I wonder if we couldn't drop exporting the symbol
instead. Since omapfb_update_window_async() is exported the same way,
are there any users outside of the tree?
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/drivers/video/fbdev/omap/omapfb.h b/drivers/video/fbdev/omap/omapfb.h
index d930152c289c..0c753ccbc1c0 100644
--- a/drivers/video/fbdev/omap/omapfb.h
+++ b/drivers/video/fbdev/omap/omapfb.h
@@ -229,5 +229,9 @@ extern int omapfb_update_window_async(struct fb_info *fbi,
struct omapfb_update_window *win,
void (*callback)(void *),
void *callback_data);
+extern int hwa742_update_window_async(struct fb_info *fbi,
+ struct omapfb_update_window *win,
+ void (*callback)(void *),
+ void *callback_data);
#endif /* __OMAPFB_H */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: omap: Add prototype for hwa742_update_window_async() to avoid build warning
2022-05-29 6:47 [PATCH] video: fbdev: omap: Add prototype for hwa742_update_window_async() to avoid build warning Helge Deller
@ 2022-05-29 11:14 ` Janusz Krzysztofik
0 siblings, 0 replies; 2+ messages in thread
From: Janusz Krzysztofik @ 2022-05-29 11:14 UTC (permalink / raw)
To: Helge Deller, Tony Lindgren, Aaro Koskinen, Tomi Valkeinen
Cc: linux-omap, linux-fbdev, linux-kernel, Imre Deak, Trilok Soni,
Janusz Krzysztofik
Hi Helge,
On Sunday, 29 May 2022 08:47:51 CEST Helge Deller wrote:
> The symbol hwa742_update_window_async() is exported, but there is no
> prototype defined for it. That's why gcc complains:
>
> drivers-video-fbdev-omap-hwa742.c:warning:no-previous-prototype-for-hwa742_update_window_async
>
> Add the prototype, but I wonder if we couldn't drop exporting the symbol
> instead. Since omapfb_update_window_async() is exported the same way,
> are there any users outside of the tree?
It looks like there are no non-local users of any of those two functions
either, so we could make them static, and I'm not aware of any out of tree
users, but let's ask more deeply involved people. Tony, Aaro, Tomi, can
you please confirm?
Thanks,
Janusz
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> diff --git a/drivers/video/fbdev/omap/omapfb.h b/drivers/video/fbdev/omap/omapfb.h
> index d930152c289c..0c753ccbc1c0 100644
> --- a/drivers/video/fbdev/omap/omapfb.h
> +++ b/drivers/video/fbdev/omap/omapfb.h
> @@ -229,5 +229,9 @@ extern int omapfb_update_window_async(struct fb_info *fbi,
> struct omapfb_update_window *win,
> void (*callback)(void *),
> void *callback_data);
> +extern int hwa742_update_window_async(struct fb_info *fbi,
> + struct omapfb_update_window *win,
> + void (*callback)(void *),
> + void *callback_data);
>
> #endif /* __OMAPFB_H */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-29 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-29 6:47 [PATCH] video: fbdev: omap: Add prototype for hwa742_update_window_async() to avoid build warning Helge Deller
2022-05-29 11:14 ` Janusz Krzysztofik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox