From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964794AbWEJEUu (ORCPT ); Wed, 10 May 2006 00:20:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964802AbWEJEUu (ORCPT ); Wed, 10 May 2006 00:20:50 -0400 Received: from wx-out-0102.google.com ([66.249.82.199]:24492 "EHLO wx-out-0102.google.com") by vger.kernel.org with ESMTP id S964794AbWEJEUt (ORCPT ); Wed, 10 May 2006 00:20:49 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=neTw4rGyPY60TxDNYdlFjvKqRof0kLp9SboSv2TmRMCE6U95y0O61YGu1nCG1vbEFCReIzzTUehDmEkTltmCv3g1rg6h+WLVBcKqK0FzO9yWP9pIyM5o2WFm1gzDEEKkl6PLukmnaex3dUZCY6RKuH1dutuLePBGPdXWFpWz4T8= Message-ID: <44616A1C.20800@gmail.com> Date: Wed, 10 May 2006 13:20:44 +0900 From: Tejun Heo User-Agent: Mail/News 1.5 (X11/20060318) MIME-Version: 1.0 To: Daniel Walker CC: akpm@osdl.org, jeremy@sgi.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm] sata_vsc gcc 4.1 warning fix References: <200605100256.k4A2u6Hu031761@dwalker1.mvista.com> In-Reply-To: <200605100256.k4A2u6Hu031761@dwalker1.mvista.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Daniel Walker wrote: > Fixes the following warning, > > drivers/scsi/sata_vsc.c:152: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:153: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:154: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:155: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:156: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:158: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:159: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:160: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:161: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:162: warning: passing argument 2 of 'writew' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:166: warning: passing argument 2 of 'writeb' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c: In function 'vsc_sata_tf_read': > drivers/scsi/sata_vsc.c:178: warning: passing argument 1 of 'readw' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:179: warning: passing argument 1 of 'readw' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:180: warning: passing argument 1 of 'readw' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:181: warning: passing argument 1 of 'readw' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:182: warning: passing argument 1 of 'readw' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:183: warning: passing argument 1 of 'readw' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c: In function 'vsc_sata_setup_port': > drivers/scsi/sata_vsc.c:320: warning: passing argument 2 of 'writel' makes pointer from integer without a cast > drivers/scsi/sata_vsc.c:321: warning: passing argument 2 of 'writel' makes pointer from integer without a cast > > Signed-Off-By: Daniel Walker > Hello, Daniel. This fix comes up every so often and I have submitted almost identical patch several months ago. Unfortunately, it's not the proper fix and won't be accepted. All those read/writeX()'s and in/outX()'s are scheduled (for a looooong time) to be converted to new unified ioread/writeX()'s. Things are in progress (well, or halt) in the #iomap branch of libata-dev devel tree. libata needs some updates in host initialization part for this conversion to complete. Thanks. -- tejun