public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "bibo,mao" <bibo_mao@linux.intel.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: mao bibo <bibo.mao@intel.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	akpm@osdl.org, Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH]x86_64 debug_stack nested patch
Date: Wed, 10 May 2006 15:44:10 +0800	[thread overview]
Message-ID: <446199CA.2030706@linux.intel.com> (raw)
In-Reply-To: <4461AD97.76E4.0078.0@novell.com>

ok, EXCEPTION_STACK_ORDER + 1 is better for me.
in_exception_stack() function is to judge which IST stack by parameter 
stack value, if DEBUG_STKSZ value is set as 8K. The original function 
can not judge whether it is within DEBUG_STACK space.

Thanks
bibo,mao

Jan Beulich wrote:
> Would you mind explaining why you
> - needed to replace the handling of the DEBUG_STKSZ > EXCEPTION_STKSZ in in_exception_stack()?
> - used a hard coded 1 instead of (EXCEPTION_STACK_ORDER + 1) for defining DEBUG_STACK_ORDER?
> 
> Thanks, Jan
> 
>>>> "bibo,mao" <bibo.mao@intel.com> 10.05.06 08:45 >>>
> hi,
> In x86_64 platform, INT1 and INT3 trap stack is IST stack called 
> DEBUG_STACK, when INT1/INT3 trap happens, system will switch to 
> DEBUG_STACK by hardware. Current DEBUG_STACK size is 4K, when int1/int3 
> trap happens, kernel will minus current DEBUG_STACK IST value by 4k. But 
> if int3/int1 trap is nested, it will destroy other vector's IST stack.
> This patch modifies this, it sets DEBUG_STACK size as 8K and allows two 
> level of nested int1/int3 trap.
> Kprobe DEBUG_STACK may be nested, because kprobe hanlder may be probed 
> by other kprobes. This patch is against 2.6.17-rc3.
> 
> Signed-Off-By: bibo, mao <bibo.mao@intel.com>
> 
> Thanks
> bibo,mao
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

  reply	other threads:[~2006-05-10  7:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-10  6:45 [PATCH]x86_64 debug_stack nested patch bibo,mao
2006-05-10  7:08 ` Jan Beulich
2006-05-10  7:44   ` bibo,mao [this message]
2006-05-10  7:56     ` Jan Beulich
2006-05-10  8:26       ` bibo,mao
2006-05-10 10:12         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446199CA.2030706@linux.intel.com \
    --to=bibo_mao@linux.intel.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=bibo.mao@intel.com \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox