From: "Jan Beulich" <jbeulich@novell.com>
To: "mao bibo" <bibo_mao@linux.intel.com>
Cc: "Anil S Keshavamurthy" <anil.s.keshavamurthy@intel.com>,
"mao bibo" <bibo.mao@intel.com>, <akpm@osdl.org>,
"Andi Kleen" <ak@suse.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]x86_64 debug_stack nested patch
Date: Wed, 10 May 2006 09:56:00 +0200 [thread overview]
Message-ID: <4461B8B0.76E4.0078.0@novell.com> (raw)
In-Reply-To: <446199CA.2030706@linux.intel.com>
>in_exception_stack() function is to judge which IST stack by parameter
>stack value, if DEBUG_STKSZ value is set as 8K. The original function
>can not judge whether it is within DEBUG_STACK space.
I rather think that the new code can't work properly. Since the pointer in the TSS gets decreased while the handler is
running, using that value is not going to tell you the end of the stack, but you'd rather get the end of the stack the
next (nested) invocation of the handler would use. Further, treating the entire DEBUG_STKSZ range as a single piece is
wrong, too, because it is not being used as a contiguous stack (but rather as 2 stacks EXCEPTION_STKSZ in size); the new
code shouldn't be able to properly deal with nested invocations because of this.
Jan
next prev parent reply other threads:[~2006-05-10 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 6:45 [PATCH]x86_64 debug_stack nested patch bibo,mao
2006-05-10 7:08 ` Jan Beulich
2006-05-10 7:44 ` bibo,mao
2006-05-10 7:56 ` Jan Beulich [this message]
2006-05-10 8:26 ` bibo,mao
2006-05-10 10:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4461B8B0.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bibo.mao@intel.com \
--cc=bibo_mao@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox