Re: [PATCH 4/6] myri10ge - First half of the driver

Roland Dreier
2006-05-10T22:04:24Z

> +typedef struct {
> + mcp_kreq_ether_recv_t __iomem *lanai; /* lanai ptr for recv ring */
> + volatile uint8_t __iomem *wc_fifo; /* w/c rx dma addr fifo address */
> + mcp_kreq_ether_recv_t *shadow; /* host shadow of recv ring */
> + struct myri10ge_rx_buffer_state *info;
> + int cnt;
> + int alloc_fail;
> + int mask; /* number of rx slots -1 */
> +} myri10ge_rx_buf_t;

Why is wc_fifo volatile? The only places you actually use it, you
seem to cast away the volatile anyway.

Also, again, no typedef of structures please.

> +#define myri10ge_pio_copy(to,from,size) __iowrite64_copy(to,from,size/8)

Why do you need this wrapper? Why not just call __iowrite64_copy()
without the obfuscation? Anyone reading the code will just have to
search back to this define and mentally translate the size back and
forth all the time.

> +int myri10ge_hyper_msi_cap_on(struct pci_dev *pdev)
> +{
> + uint8_t cap_off;
> + int nbcap = 0;
> +
> + cap_off = PCI_CAPABILITY_LIST - 1;
> + /* go through all caps looking for a hypertransport msi mapping */

This looks like something that should be fixed up in the general PCI
quirk handling rather than in every driver...

> +static int
> +myri10ge_use_msi(struct pci_dev *pdev)
> +{
> + if (myri10ge_msi == 1 || myri10ge_msi == 0)
> + return myri10ge_msi;
> +
> + /* find root complex for our device */
> + while (pdev->bus && pdev->bus->self) {
> + pdev = pdev->bus->self;
> + }

Similarly looks like generic PCI code (if it's needed at all). If I
understand correctly you're trying to check if MSI has a chance at
working on the system, but a network device driver has no business
walking up the PCI hierarchy.

> + buf = (mcp_cmd_t *) ((unsigned long)(buf_bytes + 7) & ~7UL);

ALIGN() from <linux/kernel.h>?

- R.