public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: Greg KH <gregkh@suse.de>
Cc: Dave Jones <davej@redhat.com>, Pavel Machek <pavel@suse.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	trenn@suse.de, thoenig@suse.de
Subject: Re: [RFC] [PATCH] Execute PCI quirks on resume from suspend-to-RAM
Date: Thu, 11 May 2006 17:17:00 +0200	[thread overview]
Message-ID: <4463556C.3040107@gmx.net> (raw)
In-Reply-To: <4462B737.80108@gmx.net>

Suggestion for a minimal fix for -stable:

Do not enable the SMBus device on Asus boards if software suspend
is used. We do not reenable the device on resume, leading to all sorts
of undesirable effects, the worst being a total fan failure after
resume on my Samsung P35 laptop.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

--- linux-2.6.16.14/drivers/pci/quirks.c.vanilla	2006-05-05 02:03:45.000000000 +0200
+++ linux-2.6.16.14/drivers/pci/quirks.c	2006-05-11 17:09:15.000000000 +0200
@@ -861,6 +861,8 @@
 }
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_82375,	quirk_eisa_bridge );

+#ifndef CONFIG_SOFTWARE_SUSPEND
+
 /*
  * On ASUS P4B boards, the SMBus PCI Device within the ICH2/4 southbridge
  * is not activated. The myth is that Asus said that they do not want the
@@ -1008,6 +1010,8 @@
 }
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_ICH6_1,	asus_hides_smbus_lpc_ich6 );

+#endif
+
 /*
  * SiS 96x south bridge: BIOS typically hides SMBus device...
  */


-- 
http://www.hailfinger.org/

  reply	other threads:[~2006-05-11 15:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-10  0:55 [RFC] [PATCH] Execute PCI quirks on resume from suspend-to-RAM Carl-Daniel Hailfinger
2006-05-10  9:39 ` Pavel Machek
2006-05-10 10:30   ` Carl-Daniel Hailfinger
2006-05-10 20:56     ` Greg KH
2006-05-10 21:36       ` Carl-Daniel Hailfinger
2006-05-11  2:31         ` Dave Jones
2006-05-11  4:01           ` Carl-Daniel Hailfinger
2006-05-11 15:17             ` Carl-Daniel Hailfinger [this message]
2006-05-11 15:28               ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4463556C.3040107@gmx.net \
    --to=c-d.hailfinger.devel.2006@gmx.net \
    --cc=davej@redhat.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=thoenig@suse.de \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox