2.6.17-rc4-mm1 nfsroot build err, looks related to klibc

Jim Cromie
2006-05-16T01:36:37Z

Im getting nfsroot build error on 2 configs, both carried forward
from good rc4 and from rc3-mm1 builds.
turning off nfsroot fixes the err.

[jimc@harpo linux-2.6.17-rc4-mm1-sk]$ make
CHK include/linux/version.h
CHK include/linux/compile.h
GEN .version
CHK include/linux/compile.h
UPD include/linux/compile.h
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
fs/built-in.o(.init.text+0x15d4): In function `nfs_root_setup':
fs/nfs/nfsroot.c:399: undefined reference to `root_nfs_parse_addr'
fs/built-in.o(.init.text+0x15dc):fs/nfs/nfsroot.c:399: undefined
reference to `root_server_addr'
fs/built-in.o(.init.text+0x16d6): In function `nfs_root_data':
fs/nfs/nfsroot.c:310: undefined reference to `root_server_path'
fs/built-in.o(.init.text+0x1733):fs/nfs/nfsroot.c:331: undefined
reference to `root_server_addr'
make: *** [.tmp_vmlinux1] Error 1

A little digging suggests the problem is in here:

git-klibc.patch:13607:-u32 root_server_addr = INADDR_NONE; /* Address
of NFS server */
git-klibc.patch:13840:- if (root_server_addr == INADDR_NONE)
git-klibc.patch:13841:- root_server_addr = ic_servaddr;
git-klibc.patch:14682:- * need to have root_server_addr set _before_
IPConfig gets called as it
git-klibc.patch:14752:- && root_server_addr == INADDR_NONE
git-klibc.patch:14806:- if (root_server_addr == INADDR_NONE)
git-klibc.patch:14807:- root_server_addr = addr;
git-klibc.patch:14842:- printk(", rootserver=%u.%u.%u.%u",
NIPQUAD(root_server_addr));
git-klibc.patch:78496:+static u_int32_t root_server_addr;
git-klibc.patch:78882:+ s = getenv("root_server_addr");
git-klibc.patch:78884:+ root_server_addr = strtoul(s, NULL, 10);
git-klibc.patch:78900:+ if ((servaddr = root_server_addr) ==
INADDR_NONE) {

Im likely to try taking 'static' off of line 78496,
but that lands in: devel-akpm/usr/klibc/tests/nfs_no_rpc.c
so I suspect I dont know the proper fix.
or indeed, whether it isnt a bonehead error.

thanks in advance
Jim Cromie