From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@suse.de>
Cc: <linux-kernel@vger.kernel.org>, <discuss@x86-64.org>
Subject: Re: [PATCH 2/3] reliable stack trace support (x86-64)
Date: Tue, 16 May 2006 18:06:47 +0200 [thread overview]
Message-ID: <446A14B7.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200605161713.39575.ak@suse.de>
>>> Andi Kleen <ak@suse.de> 16.05.06 17:13 >>>
On Tuesday 16 May 2006 16:21, Jan Beulich wrote:
>> These are the x86_64-specific pieces to enable reliable stack traces. The
>> only restriction with this is that it currently cannot unwind across the
>> interrupt->normal stack boundary, as that transition is lacking proper
>> annotation.
>
>It would be nice if you could submit a patch to fix that.
But I don't know how to fix it. See my other mail - I have no experience with expressions, nor have I ever seen them in
use.
>> +#define UNW_PC(frame) (frame)->regs.rip
>> +#define UNW_SP(frame) (frame)->regs.rsp
>
>I think we alreay have instruction_pointer(). Better add a stack_pointer()
>in ptrace.h too.
I could do that, but the macros will have to remain, as they don't access pt_regs directly, so I guess it'd be
pointless to change it.
Jan
next prev parent reply other threads:[~2006-05-16 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 14:21 [PATCH 2/3] reliable stack trace support (x86-64) Jan Beulich
2006-05-16 15:09 ` Ingo Molnar
2006-05-16 16:04 ` Jan Beulich
2006-05-16 15:13 ` Andi Kleen
2006-05-16 16:06 ` Jan Beulich [this message]
2006-05-16 17:05 ` [discuss] " Andi Kleen
2006-05-18 9:37 ` Jan Beulich
2006-05-18 10:20 ` Andi Kleen
2006-05-18 12:02 ` Jan Beulich
2006-05-18 12:25 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446A14B7.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox