[PATCH 11/22] [PATCH] selinux: check for failed kmalloc in security_sid_to_context()

Chris Wright
2006-05-17T22:19:09Z

[-- Attachment #1: selinux-check-for-failed-kmalloc-in-security_sid_to_context.patch --]
[-- Type: text/plain, Size: 1006 bytes --]

-stable review patch. If anyone has any objections, please let us know.
------------------

Check for NULL kmalloc return value before writing to it.

Signed-off-by: "Serge E. Hallyn" <serue@us.ibm.com>
Acked-by: James Morris <jmorris@namei.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

security/selinux/ss/services.c | 4 ++++
1 file changed, 4 insertions(+)

--- linux-2.6.16.16.orig/security/selinux/ss/services.c
+++ linux-2.6.16.16/security/selinux/ss/services.c
@@ -592,6 +592,10 @@ int security_sid_to_context(u32 sid, cha

*scontext_len = strlen(initial_sid_to_string[sid]) + 1;
scontextp = kmalloc(*scontext_len,GFP_ATOMIC);
+ if (!scontextp) {
+ rc = -ENOMEM;
+ goto out;
+ }
strcpy(scontextp, initial_sid_to_string[sid]);
*scontext = scontextp;
goto out;

--