* [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor
@ 2006-05-17 23:24 Eduard Warkentin
2006-05-17 23:59 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Eduard Warkentin @ 2006-05-17 23:24 UTC (permalink / raw)
To: linux-kernel
FROM: Eduard Warkentin <eduard.warkentin@gmx.de>
Added support for detetcion an dworking with a ASIX 88178 based USB-Gigabit
adaptor. With the patch, it is detected and handled correctly by the asix
module.
---<snip>---
--- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100
+++ ./drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200
@@ -913,6 +913,10 @@ static const struct usb_device_id produc
USB_DEVICE (0x0b95, 0x7720),
.driver_info = (unsigned long) &ax88772_info,
}, {
+ // ASIX AX88178 10/100/1000
+ USB_DEVICE (0x0b95, 0x1780),
+ .driver_info = (unsigned long) &ax88772_info,
+}, {
// Linksys USB200M Rev 2
USB_DEVICE (0x13b1, 0x0018),
.driver_info = (unsigned long) &ax88772_info,
---<snap>---
Signed-off-by: Eduard Warkentin <eduard.warkentin@gmx.de>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor
2006-05-17 23:24 [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor Eduard Warkentin
@ 2006-05-17 23:59 ` Greg KH
2006-05-18 21:52 ` Eduard Warkentin
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2006-05-17 23:59 UTC (permalink / raw)
To: Eduard Warkentin; +Cc: linux-kernel
On Thu, May 18, 2006 at 01:24:45AM +0200, Eduard Warkentin wrote:
> FROM: Eduard Warkentin <eduard.warkentin@gmx.de>
>
> Added support for detetcion an dworking with a ASIX 88178 based USB-Gigabit
> adaptor. With the patch, it is detected and handled correctly by the asix
> module.
>
> ---<snip>---
> --- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100
> +++ ./drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200
> @@ -913,6 +913,10 @@ static const struct usb_device_id produc
> USB_DEVICE (0x0b95, 0x7720),
> .driver_info = (unsigned long) &ax88772_info,
> }, {
> + // ASIX AX88178 10/100/1000
> + USB_DEVICE (0x0b95, 0x1780),
> + .driver_info = (unsigned long) &ax88772_info,
> +}, {
Hm, your tabs and spaces are messed up :(
And you didn't CC: the driver maintainer :(
> // Linksys USB200M Rev 2
> USB_DEVICE (0x13b1, 0x0018),
> .driver_info = (unsigned long) &ax88772_info,
> ---<snap>---
>
> Signed-off-by: Eduard Warkentin <eduard.warkentin@gmx.de>
And you put this at the bottom (it goes up in the changelog description)
:(
Care to try again?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor
2006-05-17 23:59 ` Greg KH
@ 2006-05-18 21:52 ` Eduard Warkentin
2006-05-18 22:14 ` Greg KH
2006-05-18 22:34 ` Eduard Warkentin
0 siblings, 2 replies; 7+ messages in thread
From: Eduard Warkentin @ 2006-05-18 21:52 UTC (permalink / raw)
To: Greg KH; +Cc: Phil Chang, linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Hi Greg!
First of all, i hope you arent angry about having me sent this reply
as CC to the current maintainer and to the mailing list. If so, I
apologize, and it wont happen in future.
> Hm, your tabs and spaces are messed up :(
I reviewed the original file again, and the lines just above mine
indeed have spare leading whitespaces. Shall I include changing them
in my patch? I really dont know wether it just will ok, or will make
it harder to identify what i actually did in patch. I have to excuse
myself for asking about those details, but this is my very first
kernel patch ever. (For now, I left the whitespaces as I found them in
the source file. Please, clue me on how to deal with those, wehen i
encounter them again.)
So, here's my corrected patch again:
FROM: Eduard Warkentin <eduard.warkentin@gmx.de>
Added support for detetcion an dworking with a ASIX 88178 based
USB-Gigabit
adaptor. With the patch, it is detected and handled correctly by the asix
module.
Signed-off-by: Eduard Warkentin <eduard.warkentin@gmx.de>
- --- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100
+++ ./drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200
@@ -913,6 +913,10 @@ static const struct usb_device_id produc
USB_DEVICE (0x0b95, 0x7720),
.driver_info = (unsigned long) &ax88772_info,
}, {
+ // ASIX AX88178 10/100/1000
+ USB_DEVICE (0x0b95, 0x1780),
+ .driver_info = (unsigned long) &ax88772_info,
+}, {
// Linksys USB200M Rev 2
USB_DEVICE (0x13b1, 0x0018),
.driver_info = (unsigned long) &ax88772_info,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEbOyK0HvYPTIhdZcRA+rAAKCAChGPNe3lCaPcZUNkJujYJmmUZgCgq6tc
bTotPl6JBMbch/DpS9O0DEQ=
=1BCn
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor
2006-05-18 21:52 ` Eduard Warkentin
@ 2006-05-18 22:14 ` Greg KH
2006-05-18 22:34 ` Eduard Warkentin
1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2006-05-18 22:14 UTC (permalink / raw)
To: Eduard Warkentin; +Cc: Phil Chang, linux-kernel
On Thu, May 18, 2006 at 11:52:11PM +0200, Eduard Warkentin wrote:
> Hi Greg!
>
> First of all, i hope you arent angry about having me sent this reply
> as CC to the current maintainer and to the mailing list. If so, I
> apologize, and it wont happen in future.
>
> > Hm, your tabs and spaces are messed up :(
> I reviewed the original file again, and the lines just above mine
> indeed have spare leading whitespaces. Shall I include changing them
> in my patch?
No, your tabs got eaten by your email client, and it happened again:
> --- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100
> +++ ./drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200
> @@ -913,6 +913,10 @@ static const struct usb_device_id produc
> USB_DEVICE (0x0b95, 0x7720),
> .driver_info = (unsigned long) &ax88772_info,
> }, {
> + // ASIX AX88178 10/100/1000
> + USB_DEVICE (0x0b95, 0x1780),
> + .driver_info = (unsigned long) &ax88772_info,
> +}, {
> // Linksys USB200M Rev 2
> USB_DEVICE (0x13b1, 0x0018),
> .driver_info = (unsigned long) &ax88772_info,
See, tabs converted to spaces, not good :(
Care for a third try?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor
2006-05-18 21:52 ` Eduard Warkentin
2006-05-18 22:14 ` Greg KH
@ 2006-05-18 22:34 ` Eduard Warkentin
2006-05-18 22:41 ` Greg KH
1 sibling, 1 reply; 7+ messages in thread
From: Eduard Warkentin @ 2006-05-18 22:34 UTC (permalink / raw)
To: Greg KH; +Cc: Phil Chang, linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Hi!
On to a third try ... carefully watched the tabs this time ...
FROM: Eduard Warkentin <eduard.warkentin@gmx.de>
Added support for detetcion an dworking with a ASIX 88178 based
USB-Gigabit adaptor. With the patch, it is detected and handled
correctly by the asix module.
Signed-off-by: Eduard Warkentin <eduard.warkentin@gmx.de>
- --- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100
+++ ./drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200
@@ -913,6 +913,10 @@ static const struct usb_device_id produc
USB_DEVICE (0x0b95, 0x7720),
.driver_info = (unsigned long) &ax88772_info,
}, {
+ // ASIX AX88178 10/100/1000
+ USB_DEVICE (0x0b95, 0x1780),
+ .driver_info = (unsigned long) &ax88772_info,
+}, {
// Linksys USB200M Rev 2
USB_DEVICE (0x13b1, 0x0018),
.driver_info = (unsigned long) &ax88772_info,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEbPZb0HvYPTIhdZcRAwmvAKDA3mf8PBDfVEj+Wz+B5sa+q60+wwCgxge9
KQ5NIjhZRo3toc6DSW3R01o=
=WG4A
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor
@ 2006-05-19 21:32 eduard.warkentin
0 siblings, 0 replies; 7+ messages in thread
From: eduard.warkentin @ 2006-05-19 21:32 UTC (permalink / raw)
To: linux-kernel; +Cc: pchang23
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 929 bytes --]
FROM: Eduard Warkentin <eduard.warkentin@gmx.de>
Added support for detetcion an dworking with a ASIX 88178 based
USB-Gigabit
adaptor. With the patch, it is detected and handled correctly by the asix
module.
Signed-off-by: Eduard Warkentin <eduard.warkentin@gmx.de>
--- drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100
+++ drivers/usb/net/asix.c 2006-05-19 23:23:00.000000000 +0200
@@ -913,6 +913,10 @@ static const struct usb_device_id produc
USB_DEVICE (0x0b95, 0x7720),
.driver_info = (unsigned long) &ax88772_info,
}, {
+ // ASIX AX88178 10/100/1000
+ USB_DEVICE (0x0b95, 0x1780),
+ .driver_info = (unsigned long) &ax88772_info,
+}, {
// Linksys USB200M Rev 2
USB_DEVICE (0x13b1, 0x0018),
.driver_info = (unsigned long) &ax88772_info,
--
Echte DSL-Flatrate dauerhaft für 0,- Euro*!
"Feel free" mit GMX DSL! http://www.gmx.net/de/go/dsl
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2006-05-19 21:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-17 23:24 [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor Eduard Warkentin
2006-05-17 23:59 ` Greg KH
2006-05-18 21:52 ` Eduard Warkentin
2006-05-18 22:14 ` Greg KH
2006-05-18 22:34 ` Eduard Warkentin
2006-05-18 22:41 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2006-05-19 21:32 eduard.warkentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox