From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932310AbWESOYu (ORCPT ); Fri, 19 May 2006 10:24:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932311AbWESOYu (ORCPT ); Fri, 19 May 2006 10:24:50 -0400 Received: from hellhawk.shadowen.org ([80.68.90.175]:18961 "EHLO hellhawk.shadowen.org") by vger.kernel.org with ESMTP id S932310AbWESOYu (ORCPT ); Fri, 19 May 2006 10:24:50 -0400 Message-ID: <446DD4CA.30606@shadowen.org> Date: Fri, 19 May 2006 15:23:06 +0100 From: Andy Whitcroft User-Agent: Debian Thunderbird 1.0.7 (X11/20051017) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mel Gorman CC: Andrew Morton , davej@codemonkey.org.uk, tony.luck@intel.com, linux-kernel@vger.kernel.org, bob.picco@hp.com, ak@suse.de, linux-mm@kvack.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 5/6] Have ia64 use add_active_range() and free_area_init_nodes References: <20060508141030.26912.93090.sendpatchset@skynet> <20060508141211.26912.48278.sendpatchset@skynet> <20060514203158.216a966e.akpm@osdl.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Mel Gorman wrote: > On Sun, 14 May 2006, Andrew Morton wrote: > >> Mel Gorman wrote: >> >>> >>> Size zones and holes in an architecture independent manner for ia64. >>> >> >> This one makes my ia64 die very early in boot. The trace is pretty >> useless. >> >> config at http://www.zip.com.au/~akpm/linux/patches/stuff/config-ia64 >> > > An indirect fix for this has been set out with a patchset with the > subject "[PATCH 0/2] Fixes for node alignment and flatmem assumptions" . > For arch-independent-zone-sizing, the issue was that FLATMEM assumes > that NODE_DATA(0)->node_start_pfn == 0. This is not the case with > arch-independent-zone-sizing and IA64. With > arch-independent-zone-sizing, a nodes node_start_pfn will be at the > first valid PFN. > >> >> >> Note the misaligned pfns. >> > > You will still get the message about misaligned PFNs on IA64. This is > because the lowest zone starts at the lowest available PFN which may not > be 0 or any other aligned number. It shouldn't make a different - or at > least I couldn't cause any problems. With the updates I sent out to the zone alignment checks yesterday this should now be ignored correctly without comment. The first zone is allowed to be misaligned because we expect alignment of the mem_map. With bob picco's patch from your set we ensure it is so. -apw