From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Giridhar Pemmasani <giri@lmc.cs.sunysb.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: __vmalloc with GFP_ATOMIC causes 'sleeping from invalid context'
Date: Mon, 22 May 2006 17:34:32 +1000 [thread overview]
Message-ID: <44716988.5010902@yahoo.com.au> (raw)
In-Reply-To: <20060522070819.23CC5EE9EE@wolfe.lmc.cs.sunysb.edu>
Giridhar Pemmasani wrote:
> On Mon, 22 May 2006 16:14:03 +1000, Nick Piggin <nickpiggin@yahoo.com.au> said:
>
> > Nick Piggin wrote:
>
> >> OTOH, it doesn't seem to be particularly wrong to allow __vmalloc
> >> GFP_ATOMIC allocations. The correct fix is to pass the gfp_mask
> >> to kmalloc: if you're worried about breaking the API, introduce a
> >> new __get_vm_area_node_mask() and implement __get_vm_area_node()
> >> as a simple wrapper that passes in GFP_KERNEL.
>
> > Oh, and __get_vm_area_node{_mask} should BUG_ON(in_interrupt());
>
> With the patch I sent earlier, this may not be required: Since
> __get_vm_area_node calls kmalloc, it should be taken care of in
> kmalloc and friends. Currently cache_alloc_debugcheck_before doesn't
> check for in_interrupt(); perhaps that is the right place to add
vmlist_lock is not irq safe. If you call it from interrupt, you can
deadlock.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-05-22 7:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 1:36 __vmalloc with GFP_ATOMIC causes 'sleeping from invalid context' Giridhar Pemmasani
2006-05-22 1:51 ` Arjan van de Ven
2006-05-22 6:01 ` Giridhar Pemmasani
2006-05-22 1:53 ` Nick Piggin
2006-05-22 5:58 ` Giridhar Pemmasani
2006-05-22 6:07 ` Nick Piggin
2006-05-22 6:10 ` Nick Piggin
2006-05-22 6:14 ` Nick Piggin
2006-05-22 7:08 ` Giridhar Pemmasani
2006-05-22 7:34 ` Nick Piggin [this message]
2006-05-22 14:55 ` Giridhar Pemmasani
2006-05-22 6:56 ` Giridhar Pemmasani
2006-05-22 21:56 ` Andrew Morton
2006-05-22 22:59 ` Giridhar Pemmasani
2006-05-22 11:18 ` Andi Kleen
2006-05-22 15:12 ` Giridhar Pemmasani
2006-05-22 11:47 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2006-10-23 6:13 Giridhar Pemmasani
2006-10-23 10:38 ` Alan Cox
2006-10-23 11:11 ` Giridhar Pemmasani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44716988.5010902@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=giri@lmc.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox