From: Martin Peschke <mp3@de.ibm.com>
To: balbir@in.ibm.com
Cc: Andrew Morton <akpm@osdl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 3/6] statistics infrastructure - prerequisite: timestamp
Date: Tue, 23 May 2006 15:33:55 +0200 [thread overview]
Message-ID: <44730F43.3050806@de.ibm.com> (raw)
In-Reply-To: <661de9470605230606l3e5fca31x5ce2be91512433@mail.gmail.com>
Balbir Singh wrote:
>> +static inline int nsec_to_timestamp(char *s, unsigned long long t)
>> +{
>> + unsigned long nsec_rem = do_div(t, 1000000000);
>
> Could we please use NSEC_PER_SEC. I cannot count the number of zeros
> after the 1.
Sure. I tried to keep my changes as small as possible ;-)
>> + return sprintf(s, "[%5lu.%06lu]", (unsigned long)t,
>> nsec_rem/1000);
>> +}
>
> Something symbolic for the 1000 would be better. NSECS_PER_USEC probably?
Makes sense.
Thanks,
Martin
next prev parent reply other threads:[~2006-05-23 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-19 16:11 [Patch 3/6] statistics infrastructure - prerequisite: timestamp Martin Peschke
2006-05-23 13:06 ` Balbir Singh
2006-05-23 13:33 ` Martin Peschke [this message]
2006-05-24 21:16 ` Tim Bird
2006-06-01 8:40 ` Martin Peschke
2006-06-01 8:50 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2006-05-24 12:31 Martin Peschke
2006-05-24 22:08 ` Andrew Morton
2006-05-24 22:45 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44730F43.3050806@de.ibm.com \
--to=mp3@de.ibm.com \
--cc=akpm@osdl.org \
--cc=balbir@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox