From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, yankejian@huawei.com,
huangdaode@hisilicon.com, lisheng011@huawei.com,
xieqianqian@huawei.com, fabf@skynet.be, lipeng321@huawei.com,
colin.king@canonical.com, simon.horman@netronome.com,
andrew@lunn.ch, ivecera@redhat.com, chenny.xu@huawei.com,
xypron.glpk@gmx.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn,
han.fei@zte.com.cn, tang.qiang007@zte.com.cn
Subject: Re: [PATCH v3] net: hns: mark symbols static where possible
Date: Tue, 04 Oct 2016 09:42:24 +0200 [thread overview]
Message-ID: <44733796.adHYRchuZI@wuerfel> (raw)
In-Reply-To: <1475309726-21334-1-git-send-email-baoyou.xie@linaro.org>
On Saturday, October 1, 2016 4:15:26 PM CEST Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous prototype for 'hns_ae_get_handle' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:274:6: warning: no previous prototype for 'hns_ae_stop' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:302:6: warning: no previous prototype for 'hns_ae_toggle_ring_irq' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:490:6: warning: no previous prototype for 'hns_ae_update_stats' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:573:6: warning: no previous prototype for 'hns_ae_get_stats' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:605:6: warning: no previous prototype for 'hns_ae_get_strings' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:638:5: warning: no previous prototype for 'hns_ae_get_sset_count' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:687:6: warning: no previous prototype for 'hns_ae_update_led_status' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:698:5: warning: no previous prototype for 'hns_ae_cpld_set_led_id' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:710:6: warning: no previous prototype for 'hns_ae_get_regs' [-Wmissing-prototypes]
> ....
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/net/ethernet/hisilicon/hip04_eth.c | 2 +-
> drivers/net/ethernet/hisilicon/hisi_femac.c | 6 ++---
These two changes have already gone in as separate patches that
you have sent earlier.
Baoyou, please stop sending patches for now until you have had
a chance to discuss your workflow with me.
You are doing something really wrong here and we need to figure
out what is causing this so you don't cause maintainers extra
work.
Arnd
prev parent reply other threads:[~2016-10-04 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 8:15 [PATCH v3] net: hns: mark symbols static where possible Baoyou Xie
2016-10-04 1:52 ` David Miller
2016-10-04 7:42 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44733796.adHYRchuZI@wuerfel \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=baoyou.xie@linaro.org \
--cc=chenny.xu@huawei.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=fabf@skynet.be \
--cc=han.fei@zte.com.cn \
--cc=huangdaode@hisilicon.com \
--cc=ivecera@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=simon.horman@netronome.com \
--cc=tang.qiang007@zte.com.cn \
--cc=xie.baoyou@zte.com.cn \
--cc=xieqianqian@huawei.com \
--cc=xypron.glpk@gmx.de \
--cc=yankejian@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox