* [PATCH] affs: possible null pointer dereference in affs_rename()
@ 2006-05-24 4:29 Florin Malita
0 siblings, 0 replies; only message in thread
From: Florin Malita @ 2006-05-24 4:29 UTC (permalink / raw)
To: zippel; +Cc: akpm, linux-kernel
If affs_bread() fails, the exit path calls mark_buffer_dirty_inode()
with a NULL argument.
Coverity CID: 312.
Signed-off-by: Florin Malita <fmalita@gmail.com>
---
diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index d4c2d63..a42143c 100644
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -416,10 +416,9 @@ affs_rename(struct inode *old_dir, struc
return retval;
}
- retval = -EIO;
bh = affs_bread(sb, old_dentry->d_inode->i_ino);
if (!bh)
- goto done;
+ return -EIO;
/* Remove header from its parent directory. */
affs_lock_dir(old_dir);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-05-24 4:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-24 4:29 [PATCH] affs: possible null pointer dereference in affs_rename() Florin Malita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox