Re: [PATCH 14/33] readahead: state based method - data structure

Andrew Morton
2006-05-26T17:06:31Z

Wu Fengguang <wfg@mail.ustc.edu.cn> wrote:
>
> #define RA_FLAG_MISS 0x01 /* a cache miss occured against this file */
> #define RA_FLAG_INCACHE 0x02 /* file is already in cache */
> +#define RA_FLAG_MMAP (1UL<<31) /* mmaped page access */
> +#define RA_FLAG_NO_LOOKAHEAD (1UL<<30) /* disable look-ahead */
> +#define RA_FLAG_EOF (1UL<<29) /* readahead hits EOF */

Odd. Why not use 4, 8, 16?