Re: [PATCH 03/33] radixtree: hole scanning functions

Andrew Morton
2006-05-26T16:20:19Z

Wu Fengguang <wfg@mail.ustc.edu.cn> wrote:
>
> On Thu, May 25, 2006 at 09:19:46AM -0700, Andrew Morton wrote:
> > Wu Fengguang <wfg@mail.ustc.edu.cn> wrote:
> > >
> > > Introduce a pair of functions to scan radix tree for hole/empty item.
> > >
> >
> > There's a userspace radix-tree test harness at
> > http://www.zip.com.au/~akpm/linux/patches/stuff/rtth.tar.gz.
> >
> > If/when these new features are merged up, it would be good to have new
> > testcases added to that suite, please.
> >
> > In the meanwhile you may care to develop those tests anwyway, see if you
> > can trip up the new features.
>
> The new radix-tree.c/.h breaks compiling terribly.

Sprinkling more stub header files in there usually fixes that.

> Are there any particular reason not to implement it as a module?

Well. It's a heck of a lot more convenient to throw testcases at a
userspace app, and to debug it and to performance analyse it.