Re: [PATCH 14/33] readahead: state based method - data structure

Wu Fengguang
2006-05-25T10:43:54Z

On Thu, May 25, 2006 at 04:03:31PM +1000, Nick Piggin wrote:
> Wu Fengguang wrote:
>
> >Extend struct file_ra_state to support the adaptive read-ahead logic.
> >
>
> Another nitpick: It is usually OK to do these things in the same patch
> that actually uses the new data (or functions -- eg. patch 15).
>
> If the addition is complex or in a completely different subsystem
> (eg. your rescue_pages function), _that_ can justify it being split
> into its own patch. Then you might also prepend the subject with mm:
> and cc linux-mm to get better reviews.

Ok, thanks for the advice.

Regards,
Wu