From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965104AbWEYKew (ORCPT ); Thu, 25 May 2006 06:34:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965112AbWEYKew (ORCPT ); Thu, 25 May 2006 06:34:52 -0400 Received: from nf-out-0910.google.com ([64.233.182.190]:63805 "EHLO nf-out-0910.google.com") by vger.kernel.org with ESMTP id S965104AbWEYKev (ORCPT ); Thu, 25 May 2006 06:34:51 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=FKtBpt3EDwVaa1IpJGfVpJFuVyc90p5W/pE7qtIkG3wvcN2Q87mognBswzatlr7bmwA2lUwheNSb9sqC/Rlt3IeqcmcLsN8d8VxV1FzDlD4mZZNb/y7fWdq+p2iGUfJOeuKKQIgttg82t6tSVwyLJ59Vl0bBLE/VNeJyE/k/9ME= Message-ID: <4475884F.1020203@gmail.com> Date: Thu, 25 May 2006 12:34:32 +0159 From: Jiri Slaby User-Agent: Thunderbird 1.5.0.2 (X11/20060501) MIME-Version: 1.0 To: Jeff Garzik CC: Greg KH , Linux Kernel Mailing List , linux-pci@atrey.karlin.mff.cuni.cz, Ralf Baechle , stevel@mvista.com Subject: Re: [PATCH 3/3] pci: gt96100eth use pci probing References: <20060525003151.598EAC7C19@atrey.karlin.mff.cuni.cz> <4474FFE1.4030202@garzik.org> <44758308.2040408@gmail.com> <447583FF.1000309@gmail.com> <447584E8.6050903@garzik.org> In-Reply-To: <447584E8.6050903@garzik.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Cc: stevel@mvista.com Jeff Garzik napsal(a): > Jiri Slaby wrote: >> Jiri Slaby napsal(a): >>> Jeff Garzik napsal(a): >>>> Jiri Slaby wrote: >>>>> +static int __init gt96100_probe1(struct pci_dev *pdev, int port_num) >>>>> { >>>>> struct gt96100_private *gp = NULL; >>>>> - struct gt96100_if_t *gtif = >96100_iflist[port_num]; >>>>> + struct gt96100_if_t *gtifs = pci_get_drvdata(pdev); >>>>> + struct gt96100_if_t *gtif = >ifs[port_num]; >>>>> int phy_addr, phy_id1, phy_id2; >>>>> u32 phyAD; >>>>> - int retval; >>>>> + int retval = -ENOMEM; >>>>> unsigned char chip_rev; >>>>> struct net_device *dev = NULL; >>>>> if (gtif->irq < 0) { >>>>> - printk(KERN_ERR "%s: irq unknown - probing not supported\n", >>>>> - __FUNCTION__); >>>>> + dev_err(&pdev->dev, "irq unknown - probing not supported\n"); >>>>> return -ENODEV; >>>>> } >>>>> + >>>>> + retval = pci_enable_device(pdev); >>>>> + if (retval) { >>>>> + dev_err(&pdev->dev, "cannot enable pci device\n"); >>>>> + return retval; >>>>> + } >>>> bug #1: please confirm pci_enable_device() is OK on this embedded >>>> hardware >>> I do not understand too much, did you mean something like this: >>> } else >>> dev_info(..., "pci device is enabled now\n"); >>> or? >> Or..., aha, I got it now. How can I confirm? > > Asking the maintainer would be a good first step. Hello, can you confirm, if calling pci_enable_device is safe for this (gt96100eth) device? thanks, -- Jiri Slaby www.fi.muni.cz/~xslaby \_.-^-._ jirislaby@gmail.com _.-^-._/ B67499670407CE62ACC8 22A032CC55C339D47A7E