Re: [PATCH 3/3] pci: gt96100eth use pci probing

[Jeff Garzik <jeff@garzik.org>]

Jiri Slaby wrote:
> Jeff Garzik napsal(a):
>> Jiri Slaby wrote:
>>>>> +unprobe:
>>>>> +    for (j = i; j > 0; j--) {
>>>>> +        struct gt96100_if_t *gtif = &gtifs[j - 1];
>>>>> +        gt96100_remove1(gtif);
>>>>> +    }
>>>>> +    kfree(gtifs);
>>>> upon failure, you fail to set drvdata back to NULL
>>> What is the purpose of setting this to NULL, other drivers don't do
>>> that too?
>> A simple grep(1) shows well over 300 cases that do this.
> But also shows the latter case: some of them do not have pci_dev_setdrv([^,]*,
> NULL) -- it finds only one occurence of that function (that set the value).

There are hundreds of occurrences of pci_set_drvdata(dev, NULL), and 
many more for non-PCI functions such as dev_set_drvdata() that do the same.

	Jeff