From: Florin Malita <fmalita@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: samuel@sortiz.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irda: missing allocation result check in irlap_change_speed()
Date: Thu, 25 May 2006 20:15:24 -0400 [thread overview]
Message-ID: <4476489C.3030808@gmail.com> (raw)
In-Reply-To: <20060525.162222.107938414.davem@davemloft.net>
David Miller wrote:
> If the allocation fails we should probably do something
> more interesting here, such as schedule a timer to try
> again later. Otherwise the speed change will silently
> never occur.
>
I thought the speed change would be piggybacked on the next frame, same
as when 'now' == 0. Is that not the case?
self->speed = speed;
/* Change speed now, or just piggyback speed on frames */
if (now) {
/* Send down empty frame to trigger speed change */
skb = dev_alloc_skb(0);
if (skb)
irlap_queue_xmit(self, skb);
}
prev parent reply other threads:[~2006-05-26 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 0:13 [PATCH] irda: missing allocation result check in irlap_change_speed() Florin Malita
2006-05-25 23:22 ` David Miller
2006-05-26 0:15 ` Florin Malita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4476489C.3030808@gmail.com \
--to=fmalita@gmail.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox