Re: [PATCH] kmalloc man page before 2.6.17

Pekka J Enberg
2006-05-26T08:03:07Z

On Fri, 26 May 2006, Paul Drynoff wrote:
> Actually, this is not full duplication:
> __do_kmalloc(size_t size, gfp_t flags,
> void *caller)
> and
> void *kmalloc(size_t size, gfp_t gfp)
>
> they have different amount of arguments and different arguments names.
>
> But as I see include/linux/slab.h is better place. See patch.
>
> It will be great to create another entry for flags of "kmalloc* family
> functions,
> so we can avoid duplication of this in __do_kmalloc and kmalloc
> comments, but I don't know is it possible with scripts/kernel-doc.
>
> Signed-off-by: Paul Drynoff <pauldrynoff@gmail.com>

Just drop the __do_kmalloc() comment completely. Did you check that
kerneldoc picks it up for the generated API docs? Btw, you should send
this to Andrew at akpm@osdl.org instead of Linus.

Pekka