From: Anssi Hannula <anssi.hannula@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: dtor_core@ameritech.net, linux-joystick@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [patch 03/13] input: make input a multi-object module
Date: Sat, 27 May 2006 00:29:36 +0300 [thread overview]
Message-ID: <44777340.7030905@gmail.com> (raw)
In-Reply-To: <20060526141603.054f0459.akpm@osdl.org>
Andrew Morton wrote:
> Anssi Hannula <anssi.hannula@gmail.com> wrote:
>
>>Move the input.c to input-core.c and modify Makefile so that the input module
>>can be built from multiple source files. This is preparing for the input-ff.c.
>>
>>Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>
>>
>>---
>> drivers/input/Makefile | 2
>> drivers/input/input-core.c | 1099 +++++++++++++++++++++++++++++++++++++++++++++
>> drivers/input/input.c | 1099 ---------------------------------------------
>
> urgh. There are other changes pending againt input.c and this renaming
> makes everything a huge pain.
>
> What does "can be built from multiple source files" mean?
Well, I want to embed the input-ff.c into the input module too.
> It would be much nicer all round if we could avoid renaming this file.
Indeed... There are these 4 options as far as I see:
1. Do this rename
2. Put all the code in input-ff.c to input.c
3. Make the input-ff a separate bool "module" and add
EXPORT_SYMBOL_GPL() for input_ff_event() which is currently the only
function in input-ff.c that is called from input.c
4. Rename the input "module" to something else, it doesn't matter so
much as almost everybody builds it as built-in anyway.
WDYT is the best one?
--
Anssi Hannula
next prev parent reply other threads:[~2006-05-26 21:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-26 16:11 [patch 00/13] input: force feedback updates, second time Anssi Hannula
2006-05-26 16:11 ` [patch 01/13] input: move fixp-arith.h to drivers/input Anssi Hannula
2006-05-26 16:11 ` [patch 02/13] input: fix accuracy of fixp-arith.h Anssi Hannula
2006-05-26 16:11 ` [patch 03/13] input: make input a multi-object module Anssi Hannula
2006-05-26 21:16 ` Andrew Morton
2006-05-26 21:29 ` Anssi Hannula [this message]
2006-05-26 21:43 ` Andrew Morton
2006-05-26 21:53 ` Anssi Hannula
2006-05-26 22:08 ` Andrew Morton
2006-05-26 22:22 ` Anssi Hannula
2006-05-26 22:32 ` Andrew Morton
2006-05-26 23:07 ` Anssi Hannula
2006-05-26 23:28 ` Andrew Morton
2006-05-26 23:35 ` Anssi Hannula
2006-05-26 23:45 ` Andrew Morton
2006-05-27 0:46 ` [patch] input: new force feedback interface Anssi Hannula
2006-05-27 0:53 ` [patch] input: use event handler in ff drivers Anssi Hannula
2006-05-26 16:11 ` [patch 04/13] input: new force feedback interface Anssi Hannula
2006-05-26 16:11 ` [patch 05/13] input: adapt hid force feedback drivers for the new interface Anssi Hannula
2006-05-26 16:11 ` [patch 06/13] input: adapt uinput for the new force feedback interface Anssi Hannula
2006-05-26 16:11 ` [patch 07/13] input: adapt iforce driver " Anssi Hannula
2006-05-26 16:11 ` [patch 08/13] input: force feedback driver for PID devices Anssi Hannula
2006-05-26 16:11 ` [patch 09/13] input: force feedback driver for Zeroplus devices Anssi Hannula
2006-05-26 16:11 ` [patch 10/13] input: update documentation of force feedback Anssi Hannula
2006-05-26 16:11 ` [patch 11/13] input: drop the remains of the old ff interface Anssi Hannula
2006-05-26 16:11 ` [patch 12/13] input: drop the old PID driver Anssi Hannula
2006-05-26 16:11 ` [patch 13/13] input: use -ENOSPC instead of -ENOMEM in iforce when device full Anssi Hannula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44777340.7030905@gmail.com \
--to=anssi.hannula@gmail.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-joystick@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox