public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anssi Hannula <anssi.hannula@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: dtor_core@ameritech.net, linux-joystick@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org
Subject: [patch] input: use event handler in ff drivers
Date: Sat, 27 May 2006 03:53:33 +0300	[thread overview]
Message-ID: <4477A30D.5030904@gmail.com> (raw)
In-Reply-To: <20060526164543.52f5b8a0.akpm@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Call input_ff_event() from drivers when they receive EV_FF event through
event() of struct input_dev.

Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>

---

This is to be applied after other patches in my last patchset.

 input/joystick/iforce/iforce-main.c |    1 +
 input/misc/uinput.c                 |    3 +++
 usb/input/hid-input.c               |    3 +++
 3 files changed, 7 insertions(+)

[-- Attachment #2: ff-refactoring-use-event-handler-in-drivers.diff --]
[-- Type: text/x-patch, Size: 1704 bytes --]

Index: linux-2.6.17-rc4-git12/drivers/usb/input/hid-input.c
===================================================================
--- linux-2.6.17-rc4-git12.orig/drivers/usb/input/hid-input.c	2006-05-27 03:45:06.000000000 +0300
+++ linux-2.6.17-rc4-git12/drivers/usb/input/hid-input.c	2006-05-27 03:45:07.000000000 +0300
@@ -717,6 +717,9 @@ static int hidinput_input_event(struct i
 	struct hid_field *field;
 	int offset;
 
+	if (type == EV_FF)
+		return input_ff_event(dev, type, code, value);
+
 	if (type != EV_LED)
 		return -1;
 
Index: linux-2.6.17-rc4-git12/drivers/input/joystick/iforce/iforce-main.c
===================================================================
--- linux-2.6.17-rc4-git12.orig/drivers/input/joystick/iforce/iforce-main.c	2006-05-27 03:45:06.000000000 +0300
+++ linux-2.6.17-rc4-git12/drivers/input/joystick/iforce/iforce-main.c	2006-05-27 03:45:07.000000000 +0300
@@ -306,6 +306,7 @@ int iforce_init_device(struct iforce *if
 	input_dev->name = "Unknown I-Force device";
 	input_dev->open = iforce_open;
 	input_dev->close = iforce_release;
+	input_dev->event = input_ff_event;
 	if (!ff_err)
 		input_dev->ff_effects_max = 10;
 
Index: linux-2.6.17-rc4-git12/drivers/input/misc/uinput.c
===================================================================
--- linux-2.6.17-rc4-git12.orig/drivers/input/misc/uinput.c	2006-05-27 03:45:06.000000000 +0300
+++ linux-2.6.17-rc4-git12/drivers/input/misc/uinput.c	2006-05-27 03:45:07.000000000 +0300
@@ -43,6 +43,9 @@ static int uinput_dev_event(struct input
 {
 	struct uinput_device	*udev;
 
+	if (type == EV_FF)
+		return input_ff_event(dev, type, code, value);
+
 	udev = dev->private;
 
 	udev->buff[udev->head].type = type;

  parent reply	other threads:[~2006-05-27  0:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-26 16:11 [patch 00/13] input: force feedback updates, second time Anssi Hannula
2006-05-26 16:11 ` [patch 01/13] input: move fixp-arith.h to drivers/input Anssi Hannula
2006-05-26 16:11 ` [patch 02/13] input: fix accuracy of fixp-arith.h Anssi Hannula
2006-05-26 16:11 ` [patch 03/13] input: make input a multi-object module Anssi Hannula
2006-05-26 21:16   ` Andrew Morton
2006-05-26 21:29     ` Anssi Hannula
2006-05-26 21:43       ` Andrew Morton
2006-05-26 21:53         ` Anssi Hannula
2006-05-26 22:08           ` Andrew Morton
2006-05-26 22:22             ` Anssi Hannula
2006-05-26 22:32               ` Andrew Morton
2006-05-26 23:07                 ` Anssi Hannula
2006-05-26 23:28                   ` Andrew Morton
2006-05-26 23:35                     ` Anssi Hannula
2006-05-26 23:45                       ` Andrew Morton
2006-05-27  0:46                         ` [patch] input: new force feedback interface Anssi Hannula
2006-05-27  0:53                         ` Anssi Hannula [this message]
2006-05-26 16:11 ` [patch 04/13] " Anssi Hannula
2006-05-26 16:11 ` [patch 05/13] input: adapt hid force feedback drivers for the new interface Anssi Hannula
2006-05-26 16:11 ` [patch 06/13] input: adapt uinput for the new force feedback interface Anssi Hannula
2006-05-26 16:11 ` [patch 07/13] input: adapt iforce driver " Anssi Hannula
2006-05-26 16:11 ` [patch 08/13] input: force feedback driver for PID devices Anssi Hannula
2006-05-26 16:11 ` [patch 09/13] input: force feedback driver for Zeroplus devices Anssi Hannula
2006-05-26 16:11 ` [patch 10/13] input: update documentation of force feedback Anssi Hannula
2006-05-26 16:11 ` [patch 11/13] input: drop the remains of the old ff interface Anssi Hannula
2006-05-26 16:11 ` [patch 12/13] input: drop the old PID driver Anssi Hannula
2006-05-26 16:11 ` [patch 13/13] input: use -ENOSPC instead of -ENOMEM in iforce when device full Anssi Hannula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4477A30D.5030904@gmail.com \
    --to=anssi.hannula@gmail.com \
    --cc=akpm@osdl.org \
    --cc=dtor_core@ameritech.net \
    --cc=linux-joystick@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox