From: Brice Goglin <brice@myri.com>
To: Rajesh Shah <rajesh.shah@intel.com>
Cc: Andrew Morton <akpm@osdl.org>, Shaohua Li <shaohua.li@intel.com>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
greg@kroah.com, tom.l.nguyen@intel.com
Subject: Re: [RFC]disable msi mode in pci_disable_device
Date: Sat, 27 May 2006 10:06:58 +0200 [thread overview]
Message-ID: <447808A2.2050709@myri.com> (raw)
In-Reply-To: <20060526161043.A16912@unix-os.sc.intel.com>
Rajesh Shah wrote:
> On Fri, May 26, 2006 at 10:26:57PM +0200, Brice Goglin wrote:
>
>> I just tried, the patch fixes our problem (no need to restore right
>> after saving to reenable MSI).
>>
>>
> Yeah, I agree this latest patch from Shaohua is the right thing,
> and that pci save/restore msi state functions should not have
> the side effect of disabling/enabling MSI. Shaohua, do drivers
> already call pci_disable_device() or will you have to patch
> them all to get the disable effect?
>
We would have to patch if we knew that disabling was required. But these
drivers that do not call pci_disable_device (for instance tg3 and bnx2)
were already working before pci_save_msi_state was added by Shaohua in
2.6.17-rc:
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=41017f0cac925e4a6bcf3359b75e5538112d4216
So they were working without any PCI core function disabling MSI for
them during suspend.
For these drivers, it might be a regression against 2.6.17-rc, but not
against 2.6.16. I'd say it's fine.
Brice
next prev parent reply other threads:[~2006-05-27 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-26 2:58 [RFC]disable msi mode in pci_disable_device Shaohua Li
2006-05-26 19:54 ` Andrew Morton
2006-05-26 20:26 ` Brice Goglin
2006-05-26 23:10 ` Rajesh Shah
2006-05-27 8:06 ` Brice Goglin [this message]
2006-05-29 2:12 ` Shaohua Li
2006-05-31 21:00 ` Linas Vepstas
2006-06-03 23:43 ` Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447808A2.2050709@myri.com \
--to=brice@myri.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=rajesh.shah@intel.com \
--cc=shaohua.li@intel.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox