From: Martin Peschke <mp3@de.ibm.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [Patch] statistics infrastructure - update 1
Date: Tue, 30 May 2006 13:22:27 +0200 [thread overview]
Message-ID: <447C2AF3.6060200@de.ibm.com> (raw)
In-Reply-To: <20060530080700.GA9419@osiris.boeblingen.de.ibm.com>
Heiko Carstens wrote:
>> case CPU_UP_PREPARE:
>> stat->pdata->ptrs[cpu] = statistic_alloc_ptr(stat, GFP_ATOMIC,
>
> Why not GFP_KERNEL?
I see. Schedule() is permitted in this context. Will change it.
>> + if (!stat->pdata->ptrs[cpu])
>> + return -ENOMEM;
>
> NOTIFY_BAD instead of -ENOMEM, I guess.
Not a bug, but slightly confusing. I think I will clean it up in my
next update patch.
>> break;
>> case CPU_UP_CANCELED:
>> case CPU_DEAD:
>
> I think your merge code (which gets called if CPU_UP_PREPARE fails) expects
> stat->pdata->ptrs[cpu] to be non-zero, right?
That's a bug and needs fixing (just bail out if pointer if zero).
Thanks, Martin
next prev parent reply other threads:[~2006-05-30 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 12:33 [Patch 5/6] statistics infrastructure Martin Peschke
2006-05-24 22:57 ` Andrew Morton
2006-05-29 22:17 ` Martin Peschke
2006-05-30 1:17 ` Andrew Morton
2006-05-29 22:17 ` [Patch] statistics infrastructure - update 1 Martin Peschke
2006-05-30 8:07 ` Heiko Carstens
2006-05-30 11:22 ` Martin Peschke [this message]
2006-05-30 17:17 ` [Patch 5/6] statistics infrastructure Martin Peschke
2006-05-30 19:19 ` Andrew Morton
2006-05-25 8:05 ` Nikita Danilov
2006-05-30 11:35 ` Martin Peschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447C2AF3.6060200@de.ibm.com \
--to=mp3@de.ibm.com \
--cc=akpm@osdl.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox