Re: [Patch] statistics infrastructure - update 1

Heiko Carstens
2006-05-30T08:07:08Z

> case CPU_UP_PREPARE:
> stat->pdata->ptrs[cpu] = statistic_alloc_ptr(stat, GFP_ATOMIC,

Why not GFP_KERNEL?

> + if (!stat->pdata->ptrs[cpu])
> + return -ENOMEM;

NOTIFY_BAD instead of -ENOMEM, I guess.

> break;
> case CPU_UP_CANCELED:
> case CPU_DEAD:

I think your merge code (which gets called if CPU_UP_PREPARE fails) expects
stat->pdata->ptrs[cpu] to be non-zero, right?