From: Arjan van de Ven <arjan@linux.intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: pauldrynoff@gmail.com, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: 2.6.17-rc5-mm1 - output of lock validator
Date: Wed, 31 May 2006 23:24:12 +0200 [thread overview]
Message-ID: <447E097C.2020707@linux.intel.com> (raw)
In-Reply-To: <20060531142525.5a22f9f1.akpm@osdl.org>
Andrew Morton wrote:
> Arjan van de Ven <arjan@linux.intel.com> wrote:
>> Andrew Morton wrote:
>>> On Wed, 31 May 2006 16:28:59 +0200
>>> Arjan van de Ven <arjan@linux.intel.com> wrote:
>>>
>>>> --- linux-2.6.17-rc5-mm1.5.orig/drivers/net/8390.c
>>>> +++ linux-2.6.17-rc5-mm1.5/drivers/net/8390.c
>>>> @@ -299,7 +299,7 @@ static int ei_start_xmit(struct sk_buff
>>>>
>>>> disable_irq_nosync(dev->irq);
>>>>
>>>> - spin_lock(&ei_local->page_lock);
>>>> + spin_lock_irqsave(&ei_local->page_lock, flags);
>>> Again, notabug - we did disable_irq().
>> but does disable_irq() work in the light of that irqpoll stuff?
>>
>
> Don't have a clue what you're referring to, sorry.
misrouted_irq() in kernel/irq/spurious.c
afaics that calls all handlers registered to the system regardless of what
irq number they are registered for.....
which breaks the disable_irq() locking trick... because your irq handler now
gets called anyway!
next prev parent reply other threads:[~2006-05-31 21:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-30 15:54 2.6.17-rc5-mm1 - doesn't boot Paul Drynoff
2006-05-30 20:25 ` Andrew Morton
2006-05-31 14:19 ` 2.6.17-rc5-mm1 - output of lock validator Paul Drynoff
2006-05-31 14:28 ` Arjan van de Ven
2006-05-31 16:38 ` Paul Drynoff
2006-05-31 23:16 ` Ingo Molnar
2006-05-31 17:21 ` Andrew Morton
2006-05-31 19:44 ` Ingo Molnar
2006-05-31 21:11 ` Andrew Morton
2006-05-31 20:35 ` Arjan van de Ven
2006-05-31 21:25 ` Andrew Morton
2006-05-31 21:24 ` Arjan van de Ven [this message]
2006-06-01 8:09 ` Herbert Xu
2006-06-01 8:12 ` Arjan van de Ven
2006-06-01 8:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447E097C.2020707@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pauldrynoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox