Re: [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext for CONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental

Ben Collins
2006-06-02T22:20:43Z

On Fri, 2006-06-02 at 23:57 +0200, Stefan Richter wrote:
> Ben Collins wrote:
> > On Fri, 2006-06-02 at 22:27 +0200, Stefan Richter wrote:
> >>It appears I will not get it fixed overnight.
> >
> >>- bool "Enable Phys DMA support for SBP2 (Debug)"
> >>- depends on IEEE1394 && IEEE1394_SBP2
> >>+ bool "Enable replacement for physical DMA in SBP2"
> >>+ depends on IEEE1394 && IEEE1394_SBP2 && EXPERIMENTAL
> >
> >
> > Please add '&& !SPARC' to the depends line. Other architectures may
> > apply, but I know for sure that this cannot be enabled on SPARC or
> > SPARC64 since the module will be unloadable due to missing symbols
> > (virt_to_bus, bus_to_virt).
>
> Are there suggestions for more architectures? PPC64?

Rather it be in the config. Plus your suggestion still makes it
unusable :)

I suggest instead doing '&& X86_32'. That should affect the least people
and keep it where it's known to work.

--
Ubuntu - http://www.ubuntu.com/
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
SwissDisk - http://www.swissdisk.com/