Re: [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext for CONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental

Stefan Richter
2006-06-02T21:59:29Z

Ben Collins wrote:
> On Fri, 2006-06-02 at 22:27 +0200, Stefan Richter wrote:
>>It appears I will not get it fixed overnight.
>
>>- bool "Enable Phys DMA support for SBP2 (Debug)"
>>- depends on IEEE1394 && IEEE1394_SBP2
>>+ bool "Enable replacement for physical DMA in SBP2"
>>+ depends on IEEE1394 && IEEE1394_SBP2 && EXPERIMENTAL
>
>
> Please add '&& !SPARC' to the depends line. Other architectures may
> apply, but I know for sure that this cannot be enabled on SPARC or
> SPARC64 since the module will be unloadable due to missing symbols
> (virt_to_bus, bus_to_virt).

Are there suggestions for more architectures? PPC64?

Or maybe I should put something into sbp2 like
#if defined(CONFIG_X86_32) || defined(CONFIG_PPC32)
a = bus_to_virt(b);
#else
printk("this functionality will be brought to you RSN");
#endif
until I had time to implement a proper mapping.
--
Stefan Richter
-=====-=-==- -==- ---=-