From: Florin Malita <fmalita@gmail.com>
To: mark.fasheh@oracle.com, kurt.hackel@oracle.com
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: [PATCH] ocfs2: dereference before NULL check in ocfs2_direct_IO_get_blocks()
Date: Sat, 03 Jun 2006 11:34:39 -0400 [thread overview]
Message-ID: <4481AC0F.6040805@gmail.com> (raw)
'bh_result' & 'inode' are explicitly checked against NULL so they
shouldn't be dereferenced prior to that.
Coverity ID: 1273, 1274.
Signed-off-by: Florin Malita <fmalita@gmail.com>
---
fs/ocfs2/aops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 47152bf..16d6478 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -559,13 +559,14 @@ static int ocfs2_direct_IO_get_blocks(st
u64 p_blkno;
int contig_blocks;
unsigned char blocksize_bits;
- unsigned long max_blocks = bh_result->b_size >> inode->i_blkbits;
+ unsigned long max_blocks;
if (!inode || !bh_result) {
mlog(ML_ERROR, "inode or bh_result is null\n");
return -EIO;
}
+ max_blocks = bh_result->b_size >> inode->i_blkbits;
blocksize_bits = inode->i_sb->s_blocksize_bits;
/* This function won't even be called if the request isn't all
next reply other threads:[~2006-06-03 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-03 15:34 Florin Malita [this message]
2006-06-03 19:15 ` [PATCH] ocfs2: dereference before NULL check in ocfs2_direct_IO_get_blocks() Alexey Dobriyan
2006-06-03 21:16 ` Joel Becker
2006-06-04 9:15 ` Arjan van de Ven
2006-06-03 23:30 ` Florin Malita
2006-06-05 16:55 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4481AC0F.6040805@gmail.com \
--to=fmalita@gmail.com \
--cc=akpm@osdl.org \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).