From: Brice Goglin <brice@myri.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Brice Goglin <brice@myri.com>, Andrew Morton <akpm@osdl.org>,
Shaohua Li <shaohua.li@intel.com>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
greg@kroah.com, tom.l.nguyen@intel.com, rajesh.shah@intel.com
Subject: Re: [RFC]disable msi mode in pci_disable_device
Date: Sat, 03 Jun 2006 19:43:43 -0400 [thread overview]
Message-ID: <44821EAF.8010003@myri.com> (raw)
In-Reply-To: <20060531210053.GE6364@austin.ibm.com>
Linas Vepstas wrote:
>> The aim is to be able to recover from a memory parity error in the NIC.
>> Such errors happen sometimes, especially when a cosmic ray comes by. To
>> recover, we restore the state that we saved at the end of the
>> initialization. As saving currently disables MSI, we currently have to
>> restore the state right after saving it at the end of the initialization
>> (see the end of
>> myri10ge_probe in http://lkml.org/lkml/2006/5/23/24).
>>
>
> My experience dealing with a similar thing suggests that its usually
> easier to restore the state to where it was after a cold boot, but
> before the device driver touched the h/w.
>
After a cold boot, some initialization is done by Linux before the
driver even touches the device (for instance the BARs). I am not sure
that restoring to the state before Linux initialized the device would be
easier than what we currently do.
Brice
prev parent reply other threads:[~2006-06-03 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-26 2:58 [RFC]disable msi mode in pci_disable_device Shaohua Li
2006-05-26 19:54 ` Andrew Morton
2006-05-26 20:26 ` Brice Goglin
2006-05-26 23:10 ` Rajesh Shah
2006-05-27 8:06 ` Brice Goglin
2006-05-29 2:12 ` Shaohua Li
2006-05-31 21:00 ` Linas Vepstas
2006-06-03 23:43 ` Brice Goglin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44821EAF.8010003@myri.com \
--to=brice@myri.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=rajesh.shah@intel.com \
--cc=shaohua.li@intel.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox